Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6826)

Unified Diff: chrome/installer/setup/brand_constants.h

Issue 2459583002: Use InstallDetails in setup. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/brand_constants.h
diff --git a/chrome/installer/setup/brand_constants.h b/chrome/installer/setup/brand_constants.h
new file mode 100644
index 0000000000000000000000000000000000000000..0a57e378180f76b6a80a5f0fcb31c725284b7704
--- /dev/null
+++ b/chrome/installer/setup/brand_constants.h
@@ -0,0 +1,37 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Defines the struct used to describe installer specific corresponding to each
robertshield 2016/11/04 12:50:35 Maybe: "Defines the struct describing installer
grt (UTC plus 2) 2016/11/08 13:02:13 Done.
+// of a brand's install modes; see chrome/install_static/install_modes.h for
+// details.
+
+#ifndef CHROME_INSTALLER_SETUP_BRAND_CONSTANTS_H_
+#define CHROME_INSTALLER_SETUP_BRAND_CONSTANTS_H_
+
+#include "base/strings/string16.h"
+
+struct BrandConstants {
+ // The brand-specific index/identifier of this instance (defined in a brand's
+ // chrome/install_static/BRAND_install_modes.h file). Index 0 is reserved for
+ // a brand's primary install mode.
+ int index;
+
+ // The command-line switch used to select this install mode.
robertshield 2016/11/04 12:50:35 Worth specifying who uses the switch? "The comman
grt (UTC plus 2) 2016/11/08 13:02:13 Done.
+ const char* install_switch;
+
+ // The suffix for the logos corresponding to this install mode for use in the
+ // Start Menu.
robertshield 2016/11/04 12:50:35 s/logos/start menu entries? Maybe call it start_m
grt (UTC plus 2) 2016/11/08 13:02:13 It really is the suffix of the artwork files refer
+ const base::char16* logo_suffix;
+
+ // True if this mode supported the (now removed) app host and launcher.
robertshield 2016/11/04 12:50:35 if this mode ever supported?
grt (UTC plus 2) 2016/11/08 13:02:13 Done.
+ bool supported_app_launcher;
+};
+
+// A brand's collection of constants correspoding to each install mode.
+extern const BrandConstants kBrandConstants[];
+
+// Returns the constants for the current install mode.
+const BrandConstants& GetBrandConstants();
+
+#endif // CHROME_INSTALLER_SETUP_BRAND_CONSTANTS_H_

Powered by Google App Engine
This is Rietveld 408576698