Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: chrome/installer/setup/brand_constants.h

Issue 2459583002: Use InstallDetails in setup. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 // Defines the struct used to describe installer specific corresponding to each
robertshield 2016/11/04 12:50:35 Maybe: "Defines the struct describing installer
grt (UTC plus 2) 2016/11/08 13:02:13 Done.
6 // of a brand's install modes; see chrome/install_static/install_modes.h for
7 // details.
8
9 #ifndef CHROME_INSTALLER_SETUP_BRAND_CONSTANTS_H_
10 #define CHROME_INSTALLER_SETUP_BRAND_CONSTANTS_H_
11
12 #include "base/strings/string16.h"
13
14 struct BrandConstants {
15 // The brand-specific index/identifier of this instance (defined in a brand's
16 // chrome/install_static/BRAND_install_modes.h file). Index 0 is reserved for
17 // a brand's primary install mode.
18 int index;
19
20 // The command-line switch used to select this install mode.
robertshield 2016/11/04 12:50:35 Worth specifying who uses the switch? "The comman
grt (UTC plus 2) 2016/11/08 13:02:13 Done.
21 const char* install_switch;
22
23 // The suffix for the logos corresponding to this install mode for use in the
24 // Start Menu.
robertshield 2016/11/04 12:50:35 s/logos/start menu entries? Maybe call it start_m
grt (UTC plus 2) 2016/11/08 13:02:13 It really is the suffix of the artwork files refer
25 const base::char16* logo_suffix;
26
27 // True if this mode supported the (now removed) app host and launcher.
robertshield 2016/11/04 12:50:35 if this mode ever supported?
grt (UTC plus 2) 2016/11/08 13:02:13 Done.
28 bool supported_app_launcher;
29 };
30
31 // A brand's collection of constants correspoding to each install mode.
32 extern const BrandConstants kBrandConstants[];
33
34 // Returns the constants for the current install mode.
35 const BrandConstants& GetBrandConstants();
36
37 #endif // CHROME_INSTALLER_SETUP_BRAND_CONSTANTS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698