Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5333)

Unified Diff: chrome/install_static/google_chrome_install_modes.cc

Issue 2459583002: Use InstallDetails in setup. (Closed)
Patch Set: compile fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/install_static/google_chrome_install_modes.cc
diff --git a/chrome/install_static/google_chrome_install_modes.cc b/chrome/install_static/google_chrome_install_modes.cc
index ad900e7f275edf405f77913ed156461fea5b49e8..fc33ed6cdee3c3c28bf5e0b28bbb6acf89150c84 100644
--- a/chrome/install_static/google_chrome_install_modes.cc
+++ b/chrome/install_static/google_chrome_install_modes.cc
@@ -22,11 +22,14 @@ const wchar_t kBinariesAppGuid[] = L"{4DC8B4CA-1BDA-483e-B5FA-D3C12E15B62D}";
const wchar_t kBinariesPathName[] = L"";
const InstallConstants kInstallModes[] = {
+ // clang-format off
// The primary install mode for stable Google Chrome.
{
sizeof(kInstallModes[0]),
STABLE_INDEX,
+ "", // No install switch for the primary install mode.
L"", // Empty install_suffix for the primary install mode.
+ L"", // No logo suffix for the primary install mode.
L"{8A69D345-D564-463c-AFF1-A69D9E530F96}",
L"", // The empty string means "stable".
ChannelStrategy::ADDITIONAL_PARAMETERS,
@@ -36,13 +39,16 @@ const InstallConstants kInstallModes[] = {
{
robertshield 2017/02/20 19:11:16 Add a comment describing this is the install mode
grt (UTC plus 2) 2017/02/21 13:21:15 Done.
sizeof(kInstallModes[0]),
CANARY_INDEX,
+ "chrome-sxs",
L" SxS",
+ L"Canary",
L"{4ea16ac7-fd5a-47c3-875b-dbf4a2008c20}",
L"canary",
ChannelStrategy::FIXED,
false, // Does not support system-level installs.
false, // Did not support multi-install.
},
+ // clang-format on
};
static_assert(_countof(kInstallModes) == NUM_INSTALL_MODES,

Powered by Google App Engine
This is Rietveld 408576698