Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: chrome/install_static/google_chrome_install_modes.cc

Issue 2459583002: Use InstallDetails in setup. (Closed)
Patch Set: compile fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Brand-specific constants and install modes for Google Chrome. 5 // Brand-specific constants and install modes for Google Chrome.
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 8
9 #include "chrome/install_static/install_modes.h" 9 #include "chrome/install_static/install_modes.h"
10 10
11 namespace install_static { 11 namespace install_static {
12 12
13 const wchar_t kCompanyPathName[] = L"Google"; 13 const wchar_t kCompanyPathName[] = L"Google";
14 14
15 const wchar_t kProductPathName[] = L"Chrome"; 15 const wchar_t kProductPathName[] = L"Chrome";
16 16
17 const size_t kProductPathNameLength = _countof(kProductPathName) - 1; 17 const size_t kProductPathNameLength = _countof(kProductPathName) - 1;
18 18
19 const wchar_t kBinariesAppGuid[] = L"{4DC8B4CA-1BDA-483e-B5FA-D3C12E15B62D}"; 19 const wchar_t kBinariesAppGuid[] = L"{4DC8B4CA-1BDA-483e-B5FA-D3C12E15B62D}";
20 20
21 // Google Chrome integrates with Google Update, so the app GUID above is used. 21 // Google Chrome integrates with Google Update, so the app GUID above is used.
22 const wchar_t kBinariesPathName[] = L""; 22 const wchar_t kBinariesPathName[] = L"";
23 23
24 const InstallConstants kInstallModes[] = { 24 const InstallConstants kInstallModes[] = {
25 // clang-format off
25 // The primary install mode for stable Google Chrome. 26 // The primary install mode for stable Google Chrome.
26 { 27 {
27 sizeof(kInstallModes[0]), 28 sizeof(kInstallModes[0]),
28 STABLE_INDEX, 29 STABLE_INDEX,
30 "", // No install switch for the primary install mode.
29 L"", // Empty install_suffix for the primary install mode. 31 L"", // Empty install_suffix for the primary install mode.
32 L"", // No logo suffix for the primary install mode.
30 L"{8A69D345-D564-463c-AFF1-A69D9E530F96}", 33 L"{8A69D345-D564-463c-AFF1-A69D9E530F96}",
31 L"", // The empty string means "stable". 34 L"", // The empty string means "stable".
32 ChannelStrategy::ADDITIONAL_PARAMETERS, 35 ChannelStrategy::ADDITIONAL_PARAMETERS,
33 true, // Supports system-level installs. 36 true, // Supports system-level installs.
34 true, // Supported multi-install. 37 true, // Supported multi-install.
35 }, 38 },
36 { 39 {
robertshield 2017/02/20 19:11:16 Add a comment describing this is the install mode
grt (UTC plus 2) 2017/02/21 13:21:15 Done.
37 sizeof(kInstallModes[0]), 40 sizeof(kInstallModes[0]),
38 CANARY_INDEX, 41 CANARY_INDEX,
42 "chrome-sxs",
39 L" SxS", 43 L" SxS",
44 L"Canary",
40 L"{4ea16ac7-fd5a-47c3-875b-dbf4a2008c20}", 45 L"{4ea16ac7-fd5a-47c3-875b-dbf4a2008c20}",
41 L"canary", 46 L"canary",
42 ChannelStrategy::FIXED, 47 ChannelStrategy::FIXED,
43 false, // Does not support system-level installs. 48 false, // Does not support system-level installs.
44 false, // Did not support multi-install. 49 false, // Did not support multi-install.
45 }, 50 },
51 // clang-format on
46 }; 52 };
47 53
48 static_assert(_countof(kInstallModes) == NUM_INSTALL_MODES, 54 static_assert(_countof(kInstallModes) == NUM_INSTALL_MODES,
49 "Imbalance between kInstallModes and InstallConstantIndex"); 55 "Imbalance between kInstallModes and InstallConstantIndex");
50 56
51 } // namespace install_static 57 } // namespace install_static
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698