[promises] Move CreateResolvingFunctions to c++

src/bootstrapper.cc

Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index 143c00154c63b56304706f0c0515b93106b614d4..8e4110226d5d573b45bc1d76e3c27664e33cf92f 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -3597,6 +3597,34 @@ bool Genesis::InstallNatives(GlobalContextType context_type) {
         *isolate()->builtins()->JSBuiltinsConstructStub());
     InstallWithIntrinsicDefaultProto(isolate(), function,
                                      Context::PROMISE_FUNCTION_INDEX);
+
+    {
+      Handle<String> name = isolate()->factory()->InternalizeUtf8String("");

[adamk, 2016/11/08 18:09:54]

You can use factory()->empty_string()

[gsathya, 2016/11/08 20:03:18]

Done.

+      Handle<Code> code = handle(
+          isolate()->builtins()->builtin(Builtins::kPromiseResolveClosure),
+          isolate());
+      Handle<SharedFunctionInfo> info =
+          isolate()->factory()->NewSharedFunctionInfo(name, code, false);
+      info->set_internal_formal_parameter_count(1);
+      info->set_length(1);
+      native_context()->set_promise_resolve_shared_fun(*info);

[adamk, 2016/11/08 18:09:54]

Why are we storing these per context? Could we instead store them per-Isolate?

+
+      name = isolate()->factory()->InternalizeUtf8String("");
+      code = handle(
+          isolate()->builtins()->builtin(Builtins::kPromiseRejectClosure),
+          isolate());
+      info = isolate()->factory()->NewSharedFunctionInfo(name, code, false);
+      info->set_internal_formal_parameter_count(2);
+      info->set_length(1);
+      native_context()->set_promise_reject_shared_fun(*info);
+    }
+
+    Handle<JSFunction> create_resolving_functions = SimpleCreateFunction(
+        isolate(),
+        factory()->InternalizeUtf8String("create_resolving_functions"),
+        Builtins::kCreateResolvingFunctions, 2, false);
+    native_context()->set_create_resolving_functions(
+        *create_resolving_functions);
   }
 
   InstallBuiltinFunctionIds();