[promises] Move CreateResolvingFunctions to c++

src/bootstrapper.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/bootstrapper.h"
 
 #include "src/accessors.h"
 #include "src/api-natives.h"
 #include "src/base/ieee754.h"
 #include "src/code-stubs.h"
@@ skipping 3579 matching lines @@
   {
     Handle<String> key = factory()->Promise_string();
     Handle<JSFunction> function = Handle<JSFunction>::cast(
         JSReceiver::GetProperty(global_object, key).ToHandleChecked());
     JSFunction::EnsureHasInitialMap(function);
     function->initial_map()->set_instance_type(JS_PROMISE_TYPE);
     function->shared()->SetConstructStub(
         *isolate()->builtins()->JSBuiltinsConstructStub());
     InstallWithIntrinsicDefaultProto(isolate(), function,
                                      Context::PROMISE_FUNCTION_INDEX);
+
+    {
+      Handle<String> name = isolate()->factory()->InternalizeUtf8String("");

[adamk, 2016/11/08 18:09:54]

You can use factory()->empty_string()

[gsathya, 2016/11/08 20:03:18]

Done.

+      Handle<Code> code = handle(
+          isolate()->builtins()->builtin(Builtins::kPromiseResolveClosure),
+          isolate());
+      Handle<SharedFunctionInfo> info =
+          isolate()->factory()->NewSharedFunctionInfo(name, code, false);
+      info->set_internal_formal_parameter_count(1);
+      info->set_length(1);
+      native_context()->set_promise_resolve_shared_fun(*info);

[adamk, 2016/11/08 18:09:54]

Why are we storing these per context? Could we instead store them per-Isolate?

+
+      name = isolate()->factory()->InternalizeUtf8String("");
+      code = handle(
+          isolate()->builtins()->builtin(Builtins::kPromiseRejectClosure),
+          isolate());
+      info = isolate()->factory()->NewSharedFunctionInfo(name, code, false);
+      info->set_internal_formal_parameter_count(2);
+      info->set_length(1);
+      native_context()->set_promise_reject_shared_fun(*info);
+    }
+
+    Handle<JSFunction> create_resolving_functions = SimpleCreateFunction(
+        isolate(),
+        factory()->InternalizeUtf8String("create_resolving_functions"),
+        Builtins::kCreateResolvingFunctions, 2, false);
+    native_context()->set_create_resolving_functions(
+        *create_resolving_functions);
   }
 
   InstallBuiltinFunctionIds();
 
   // Create a map for accessor property descriptors (a variant of JSObject
   // that predefines four properties get, set, configurable and enumerable).
   {
     // AccessorPropertyDescriptor initial map.
     Handle<Map> map =
         factory()->NewMap(JS_OBJECT_TYPE, JSAccessorPropertyDescriptor::kSize);
@@ skipping 930 matching lines @@
 }
 
 
 // Called when the top-level V8 mutex is destroyed.
 void Bootstrapper::FreeThreadResources() {
   DCHECK(!IsActive());
 }
 
 }  // namespace internal
 }  // namespace v8