Consolidate implementation of ImageBitmapRenderingContext

Consolidate implementation of ImageBitmapRenderingContext

To prepare for the shipping of ImageBitmapRenderingContext, we need more
layout test coverage. When we add more tests, we found that there are
some problem in our implementation.

1. transferFromImageBitmap API should be capable of throwing DOMException.
2. After calling transferFromImageBitmap(bitmap), the bitmap should be
   detached.
3. When calling transferFromImageBitmap(bitmap), if bitmap has already
   detached, this call should throw an InvalidStateError DOMException.

The corresponding layout test cases are added.

BUG=659156
Committed: https://crrev.com/300be765de46941accbb0d12fee1dba27fd06bb0
Committed: https://crrev.com/807358546cf4a8451044f63c3198039004f80de1
Cr-Original-Commit-Position: refs/heads/master@{#428988}
Cr-Commit-Position: refs/heads/master@{#430954}

[xidachen, 2016-10-31 02:07:48]

xidachen@chromium.org changed reviewers:
+ junov@chromium.org

[xidachen, 2016-10-31 02:07:49]

PTAL

[Justin Novosad, 2016-10-31 14:04:39]

lgtm with nit

https://codereview.chromium.org/2459233002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-nullability.html
(right):

https://codereview.chromium.org/2459233002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-nullability.html:37:
assert_throws("InvalidStateError", function()
{bitmapCtx.transferFromImageBitmap(image);});
Would be cleaner to put this in a separate test. This part has nothing to do
with nullability.

[xidachen, 2016-10-31 14:24:38]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 14:24:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 16:03:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 16:03:55]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[xidachen, 2016-11-01 01:42:15]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 01:42:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xidachen, 2016-11-01 02:39:41]

The CQ bit was unchecked by xidachen@chromium.org

[xidachen, 2016-11-01 12:11:42]

The CQ bit was checked by xidachen@chromium.org

[xidachen, 2016-11-01 12:11:43]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2459233002/#ps40001
(title: "fix a layout test failure")

[commit-bot: I haz the power, 2016-11-01 12:11:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 13:18:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-01 13:20:54]

Description was changed from

==========
Consolidate implementation of ImageBitmapRenderingContext

To prepare for the shipping of ImageBitmapRenderingContext, we need more
layout test coverage. When we add more tests, we found that there are
some problem in our implementation.

1. transferFromImageBitmap API should be capable of throwing DOMException.
2. After calling transferFromImageBitmap(bitmap), the bitmap should be
   detached.
3. When calling transferFromImageBitmap(bitmap), if bitmap has already
   detached, this call should throw an InvalidStateError DOMException.

The corresponding layout test cases are added.

BUG=659156
==========

to

==========
Consolidate implementation of ImageBitmapRenderingContext

To prepare for the shipping of ImageBitmapRenderingContext, we need more
layout test coverage. When we add more tests, we found that there are
some problem in our implementation.

1. transferFromImageBitmap API should be capable of throwing DOMException.
2. After calling transferFromImageBitmap(bitmap), the bitmap should be
   detached.
3. When calling transferFromImageBitmap(bitmap), if bitmap has already
   detached, this call should throw an InvalidStateError DOMException.

The corresponding layout test cases are added.

BUG=659156

Committed: https://crrev.com/300be765de46941accbb0d12fee1dba27fd06bb0
Cr-Commit-Position: refs/heads/master@{#428988}
==========

[commit-bot: I haz the power, 2016-11-01 13:20:55]

Patchset 3 (id:??) landed as
https://crrev.com/300be765de46941accbb0d12fee1dba27fd06bb0
Cr-Commit-Position: refs/heads/master@{#428988}

[please use gerrit instead, 2016-11-01 14:50:05]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2464093002/ by rouslan@chromium.org.

The reason for reverting is: Speculative revert to fix
offscreenCanvas-transferToImageBitmap-texImage2D.html.

Failed build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precis...

Error message is not helpful: "renderer crashed.".

[xidachen, 2016-11-09 13:40:23]

junov@: Let's re-land this CL. I just did a rebase and there is nothing to
change.

After our previous CL landed: https://codereview.chromium.org/2455983005/, the
crash no longer exist.

I ran all layout tests with --enable-leak-detection, under fast/canvas,
virtual/gpu/fast/canvas, virtual/display_list_2d_canvas/fast/canvas, and they
are all fine. So this CL should be good now.

[Justin Novosad, 2016-11-09 15:20:24]

On 2016/11/09 13:40:23, xidachen wrote:
> junov@: Let's re-land this CL. I just did a rebase and there is nothing to
> change.
> 
> After our previous CL landed: https://codereview.chromium.org/2455983005/, the
> crash no longer exist.
> 
> I ran all layout tests with --enable-leak-detection, under fast/canvas,
> virtual/gpu/fast/canvas, virtual/display_list_2d_canvas/fast/canvas, and they
> are all fine. So this CL should be good now.

sweet. lgtm to re-land

[xidachen, 2016-11-09 15:22:41]

Description was changed from

==========
Consolidate implementation of ImageBitmapRenderingContext

To prepare for the shipping of ImageBitmapRenderingContext, we need more
layout test coverage. When we add more tests, we found that there are
some problem in our implementation.

1. transferFromImageBitmap API should be capable of throwing DOMException.
2. After calling transferFromImageBitmap(bitmap), the bitmap should be
   detached.
3. When calling transferFromImageBitmap(bitmap), if bitmap has already
   detached, this call should throw an InvalidStateError DOMException.

The corresponding layout test cases are added.

BUG=659156

Committed: https://crrev.com/300be765de46941accbb0d12fee1dba27fd06bb0
Cr-Commit-Position: refs/heads/master@{#428988}
==========

to

==========
Consolidate implementation of ImageBitmapRenderingContext

To prepare for the shipping of ImageBitmapRenderingContext, we need more
layout test coverage. When we add more tests, we found that there are
some problem in our implementation.

1. transferFromImageBitmap API should be capable of throwing DOMException.
2. After calling transferFromImageBitmap(bitmap), the bitmap should be
   detached.
3. When calling transferFromImageBitmap(bitmap), if bitmap has already
   detached, this call should throw an InvalidStateError DOMException.

The corresponding layout test cases are added.

BUG=659156

Committed: https://crrev.com/300be765de46941accbb0d12fee1dba27fd06bb0
Cr-Commit-Position: refs/heads/master@{#428988}
==========

[xidachen, 2016-11-09 15:22:50]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 15:23:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 16:55:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 16:55:53]

Dry run: This issue passed the CQ dry run.

[xidachen, 2016-11-09 16:57:02]

The CQ bit was checked by xidachen@chromium.org

[commit-bot: I haz the power, 2016-11-09 16:57:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 17:03:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 17:03:09]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[commit-bot: I haz the power, 2016-11-09 17:07:10]

Description was changed from

==========
Consolidate implementation of ImageBitmapRenderingContext

To prepare for the shipping of ImageBitmapRenderingContext, we need more
layout test coverage. When we add more tests, we found that there are
some problem in our implementation.

1. transferFromImageBitmap API should be capable of throwing DOMException.
2. After calling transferFromImageBitmap(bitmap), the bitmap should be
   detached.
3. When calling transferFromImageBitmap(bitmap), if bitmap has already
   detached, this call should throw an InvalidStateError DOMException.

The corresponding layout test cases are added.

BUG=659156

Committed: https://crrev.com/300be765de46941accbb0d12fee1dba27fd06bb0
Cr-Commit-Position: refs/heads/master@{#428988}
==========

to

==========
Consolidate implementation of ImageBitmapRenderingContext

To prepare for the shipping of ImageBitmapRenderingContext, we need more
layout test coverage. When we add more tests, we found that there are
some problem in our implementation.

1. transferFromImageBitmap API should be capable of throwing DOMException.
2. After calling transferFromImageBitmap(bitmap), the bitmap should be
   detached.
3. When calling transferFromImageBitmap(bitmap), if bitmap has already
   detached, this call should throw an InvalidStateError DOMException.

The corresponding layout test cases are added.

BUG=659156

Committed: https://crrev.com/300be765de46941accbb0d12fee1dba27fd06bb0
Committed: https://crrev.com/807358546cf4a8451044f63c3198039004f80de1
Cr-Original-Commit-Position: refs/heads/master@{#428988}
Cr-Commit-Position: refs/heads/master@{#430954}
==========

[commit-bot: I haz the power, 2016-11-09 17:07:11]

Patchset 3 (id:??) landed as
https://crrev.com/807358546cf4a8451044f63c3198039004f80de1
Cr-Commit-Position: refs/heads/master@{#430954}