Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2459213003: Symbolize all unsymbolized minidumps upon unexpected test failure. (Closed)

Created:
4 years, 1 month ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
Zhenyao Mo, vmiura
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, nednguyen, eyaich1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Symbolize all unsymbolized minidumps upon unexpected test failure. This should provide reasonable diagnosis of the random GPU process crahes seen running the WebGL conformance tests. BUG=596622, 619264 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=vmiura@chromium.org,zmo@chromium.org Committed: https://crrev.com/03ca36583160b14b922b4697cd63afd573abb5d5 Cr-Commit-Position: refs/heads/master@{#428636}

Patch Set 1 #

Patch Set 2 : Only symbolize minidumps for tests expected to pass, but which failed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M content/test/gpu/gpu_tests/gpu_integration_test.py View 1 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Ken Russell (switch to Gerrit)
Victor, Mo: I'm CQ'ing this TBR'd as I've already tested it locally with failure injection. ...
4 years, 1 month ago (2016-10-30 22:58:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459213003/20001
4 years, 1 month ago (2016-10-30 22:59:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 00:04:53 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 00:08:36 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/03ca36583160b14b922b4697cd63afd573abb5d5
Cr-Commit-Position: refs/heads/master@{#428636}

Powered by Google App Engine
This is Rietveld 408576698