Symbolize all unsymbolized minidumps upon unexpected test failure.

content/test/gpu/gpu_tests/gpu_integration_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from telemetry.testing import serially_executed_browser_test_case
 from telemetry.util import screenshot
 
 from gpu_tests import exception_formatter
@@ skipping 63 matching lines @@
       # Perhaps only if multiple arguments are yielded in the test
       # generator?
       if len(args) == 1 and isinstance(args[0], tuple):
         args = args[0]
       self.RunActualGpuTest(url, *args)
     except Exception:
       if expectation == 'pass':
         # This is not an expected exception or test failure, so print
         # the detail to the console.
         exception_formatter.PrintFormattedException()
+        # Symbolize any crash dump (like from the GPU process) that
+        # might have happened but wasn't detected above. Note we don't
+        # do this for either 'fail' or 'flaky' expectations because
+        # there are still quite a few flaky failures in the WebGL test
+        # expectations, and since minidump symbolization is slow
+        # (upwards of one minute on a fast laptop), symbolizing all the
+        # stacks could slow down the tests' running time unacceptably.
+        self._SymbolizeUnsymbolizedMinidumps()
         # This failure might have been caused by a browser or renderer
         # crash, so restart the browser to make sure any state doesn't
         # propagate to the next test iteration.
         self._RestartBrowser('unexpected test failure')
         raise
       elif expectation == 'fail':
         msg = 'Expected exception while running %s' % test_name
         exception_formatter.PrintFormattedException(msg=msg)
         # Even though this is a known failure, the browser might still
         # be in a bad state; for example, certain kinds of timeouts
@@ skipping 27 matching lines @@
           if ii == num_retries - 1:
             # Restart the browser after the last failure to make sure
             # any state doesn't propagate to the next iteration.
             self._RestartBrowser('excessive flaky test failures')
             raise
     else:
       if expectation == 'fail':
         logging.warning(
             '%s was expected to fail, but passed.\n', test_name)
 
+  def _SymbolizeUnsymbolizedMinidumps(self):
+    # The fakes used for unit tests don't mock this entry point yet.
+    if not hasattr(self.browser, 'GetAllUnsymbolizedMinidumpPaths'):
+      return
+    i = 10
+    if self.browser.GetAllUnsymbolizedMinidumpPaths():
+      logging.error('Symbolizing minidump paths: ' + str(
+        self.browser.GetAllUnsymbolizedMinidumpPaths()))
+    else:
+      logging.error('No minidump paths to symbolize')
+    while i > 0 and self.browser.GetAllUnsymbolizedMinidumpPaths():
+      i = i - 1
+      sym = self.browser.SymbolizeMinidump(
+        self.browser.GetAllUnsymbolizedMinidumpPaths()[0])
+      if sym[0]:
+        logging.error('Symbolized minidump:\n' + sym[1])
+      else:
+        logging.error('Minidump symbolization failed:\n' + sym[1])
+
   @classmethod
   def GenerateGpuTests(cls, options):
     """Subclasses must implement this to yield (test_name, url, args)
     tuples of tests to run."""
     raise NotImplementedError
 
   def RunActualGpuTest(self, file_path, *args):
     """Subclasses must override this to run the actual test at the given
     URL. file_path is a path on the local file system that may need to
     be resolved via UrlOfStaticFilePath.
@@ skipping 24 matching lines @@
       cls.tab = cls.browser.tabs[0]
     except Exception:
       # restart the browser to make sure a failure in a test doesn't
       # propagate to the next test iteration.
       logging.exception("Failure during browser startup")
       cls._RestartBrowser('failure in setup')
       raise
 
   def setUp(self):
     self._EnsureTabIsAvailable()