content/renderer/render_frame_impl.cc - Issue 2459143002: Avoid GURL allocations/copies/frees in RenderFrameImpl::willSendRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2459143002: Avoid GURL allocations/copies/frees in RenderFrameImpl::willSendRequest (Closed)

Patch Set: s/host/host_piece Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index bee026175e79ff5c42fd25df1a450f226d22654c..a554c9ed4ef36f48d3d866aa91dac4d109d75359 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -4167,13 +4167,11 @@ void RenderFrameImpl::willSendRequest(blink::WebLocalFrame* frame,

transition_type | ui::PAGE_TRANSITION_CLIENT_REDIRECT);

}

- GURL request_url(request.url());

GURL new_url;

if (GetContentClient()->renderer()->WillSendRequest(

frame,

transition_type,

- request_url,

- request.firstPartyForCookies(),

+ request.url(),

&new_url)) {

request.setURL(WebURL(new_url));

}