content/public/renderer/content_renderer_client.cc - Issue 2459143002: Avoid GURL allocations/copies/frees in RenderFrameImpl::willSendRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/content_renderer_client.cc

Issue 2459143002: Avoid GURL allocations/copies/frees in RenderFrameImpl::willSendRequest (Closed)

Patch Set: s/host/host_piece Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/renderer/content_renderer_client.cc

diff --git a/content/public/renderer/content_renderer_client.cc b/content/public/renderer/content_renderer_client.cc

index 82daaaa06038b8e1a2ccf3e2317a51c127f8ae08..f35db62b9fb8d75d86a0a384a7ebac1581deead6 100644

--- a/content/public/renderer/content_renderer_client.cc

+++ b/content/public/renderer/content_renderer_client.cc

@@ -130,8 +130,7 @@ bool ContentRendererClient::ShouldFork(blink::WebLocalFrame* frame,

bool ContentRendererClient::WillSendRequest(

blink::WebFrame* frame,

ui::PageTransition transition_type,

- const GURL& url,

- const GURL& first_party_for_cookies,

+ const blink::WebURL& url,

GURL* new_url) {

return false;

}