Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2459063002: [Mac] Version the Chromium Framework if enable_xpc_notifications is true. (Closed)

Created:
4 years, 1 month ago by Robert Sesek
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Version the Chromium Framework if enable_xpc_notifications is true. This is to support XPCServices, which require that the framework directory be versioned in order to locate the service. BUG=604809 Committed: https://crrev.com/b233427ef84931c5ae089e5e6b13743ab597de9d Cr-Commit-Position: refs/heads/master@{#428491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Robert Sesek
4 years, 1 month ago (2016-10-28 20:41:52 UTC) #6
Dirk Pranke
lgtm
4 years, 1 month ago (2016-10-28 20:56:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459063002/1
4 years, 1 month ago (2016-10-28 21:05:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 21:12:14 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 21:15:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b233427ef84931c5ae089e5e6b13743ab597de9d
Cr-Commit-Position: refs/heads/master@{#428491}

Powered by Google App Engine
This is Rietveld 408576698