Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: chrome/BUILD.gn

Issue 2459063002: [Mac] Version the Chromium Framework if enable_xpc_notifications is true. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index ff39b519d94dde85d8a23cbab717a763e9cf01a5..d5a3f5db0e59b7773d520f5ac77a66f2afd3ff2f 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -951,6 +951,7 @@ if (is_win) {
target(_dll_target_type, "chrome_dll") {
visibility = [
":chrome_framework",
+ ":chrome_framework_create_bundle",
":chrome_framework_shared_library",
]
@@ -1001,6 +1002,10 @@ if (is_win) {
mac_framework_bundle("chrome_framework") {
output_name = chrome_framework_name
+ if (enable_xpc_notifications) {
+ framework_version = "A"
+ }
+
configs += [ "//build/config/compiler:wexit_time_destructors" ]
info_plist_target = ":chrome_framework_plist"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698