Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2459003002: [heap] Check that sweeping is completed when collecting evacuation (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Check that sweeping is completed when collecting evacuation candidates. BUG=chromium:650314 Committed: https://crrev.com/b0b1d7a9e6e199978c2c92aebcc592e720743de2 Cr-Commit-Position: refs/heads/master@{#40651}

Patch Set 1 #

Patch Set 2 : use dcheck #

Patch Set 3 : fix ce #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/heap/mark-compact.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
ulan
ptal
4 years, 1 month ago (2016-10-28 14:18:26 UTC) #2
Michael Lippautz
lgtm
4 years, 1 month ago (2016-10-28 14:30:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459003002/20001
4 years, 1 month ago (2016-10-28 15:13:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/11324) v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-10-28 15:15:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459003002/40001
4 years, 1 month ago (2016-10-28 16:19:05 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-28 16:53:19 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:17:02 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b0b1d7a9e6e199978c2c92aebcc592e720743de2
Cr-Commit-Position: refs/heads/master@{#40651}

Powered by Google App Engine
This is Rietveld 408576698