Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: src/heap/mark-compact.cc

Issue 2459003002: [heap] Check that sweeping is completed when collecting evacuation (Closed)
Patch Set: fix ce Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/mark-compact.cc
diff --git a/src/heap/mark-compact.cc b/src/heap/mark-compact.cc
index 1a85216e3ff6ce84299081d8bbe3414b6f2a1319..81122da6213bec889b403be6180bbd21d043b46c 100644
--- a/src/heap/mark-compact.cc
+++ b/src/heap/mark-compact.cc
@@ -638,6 +638,9 @@ void MarkCompactCollector::CollectEvacuationCandidates(PagedSpace* space) {
std::vector<LiveBytesPagePair> pages;
pages.reserve(number_of_pages);
+ DCHECK(!sweeping_in_progress());
+ DCHECK(!FLAG_concurrent_sweeping ||
+ sweeper().IsSweepingCompleted(space->identity()));
for (Page* p : *space) {
if (p->NeverEvacuate()) continue;
// Invariant: Evacuation candidates are just created when marking is
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698