Support 2D texture sub-source uploads from HTMLImageElement.

Support 2D texture sub-source uploads from HTMLImageElement.

Covers both texImage2D and texSubImage2D.

Verified with new tests in https://github.com/KhronosGroup/WebGL/pull/2119 .

Other code paths will follow.

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/936bf933e5b57ed08bc8ff211233a21783260615
Cr-Commit-Position: refs/heads/master@{#428889}

[Ken Russell (switch to Gerrit), 2016-10-28 07:48:32]

Description was changed from

==========
Support 2D texture sub-source uploads from HTMLImageElement.

Covers both texImage2D and texSubImage2D.

BUG=639145
==========

to

==========
Support 2D texture sub-source uploads from HTMLImageElement.

Covers both texImage2D and texSubImage2D.

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-10-28 07:48:33]

Description was changed from

==========
Support 2D texture sub-source uploads from HTMLImageElement.

Covers both texImage2D and texSubImage2D.

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Support 2D texture sub-source uploads from HTMLImageElement.

Covers both texImage2D and texSubImage2D.

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-10-28 20:27:49]

Description was changed from

==========
Support 2D texture sub-source uploads from HTMLImageElement.

Covers both texImage2D and texSubImage2D.

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Support 2D texture sub-source uploads from HTMLImageElement.

Covers both texImage2D and texSubImage2D.

Verified with new tests in https://github.com/KhronosGroup/WebGL/pull/2119 .

Other code paths will follow.

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-10-28 20:28:03]

kbr@chromium.org changed reviewers:
+ kainino@chromium.org, zmo@chromium.org

[Ken Russell (switch to Gerrit), 2016-10-28 20:28:04]

PTAL

[Ken Russell (switch to Gerrit), 2016-10-28 20:28:30]

The CQ bit was checked by kbr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 20:29:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 21:28:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 21:28:30]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Zhenyao Mo, 2016-10-29 00:28:39]

On 2016/10/28 20:28:04, Ken Russell wrote:
> PTAL

The bot failures seem real

[Ken Russell (switch to Gerrit), 2016-10-30 21:43:38]

On 2016/10/29 00:28:39, Zhenyao Mo wrote:
> On 2016/10/28 20:28:04, Ken Russell wrote:
> > PTAL
> 
> The bot failures seem real

You are correct; they were. Fixed now. Please take another look.

[Ken Russell (switch to Gerrit), 2016-10-30 21:43:44]

The CQ bit was checked by kbr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-30 21:43:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-30 23:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-30 23:19:27]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2016-10-31 22:50:51]

LGTM with one tiny suggestion
Let's land this now

https://codereview.chromium.org/2458943002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2458943002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4371:
synthesizeGLError(GL_INVALID_OPERATION, funcName,
Should we generate INVALID_VALUE here? subRect's width() and height() is the
original args width/height, which generates INVALID_VALUE if negative.

[Zhenyao Mo, 2016-10-31 22:50:55]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-10-31 22:51:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2016-11-01 00:31:34]

https://codereview.chromium.org/2458943002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2458943002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4371:
synthesizeGLError(GL_INVALID_OPERATION, funcName,
On 2016/10/31 22:50:51, Zhenyao Mo wrote:
> Should we generate INVALID_VALUE here? subRect's width() and height() is the
> original args width/height, which generates INVALID_VALUE if negative.

Thanks, good point; I'll address this in a follow-on patch (and test it).

[commit-bot: I haz the power, 2016-11-01 00:54:09]

Description was changed from

==========
Support 2D texture sub-source uploads from HTMLImageElement.

Covers both texImage2D and texSubImage2D.

Verified with new tests in https://github.com/KhronosGroup/WebGL/pull/2119 .

Other code paths will follow.

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Support 2D texture sub-source uploads from HTMLImageElement.

Covers both texImage2D and texSubImage2D.

Verified with new tests in https://github.com/KhronosGroup/WebGL/pull/2119 .

Other code paths will follow.

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-01 00:54:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-01 00:56:43]

Description was changed from

==========
Support 2D texture sub-source uploads from HTMLImageElement.

Covers both texImage2D and texSubImage2D.

Verified with new tests in https://github.com/KhronosGroup/WebGL/pull/2119 .

Other code paths will follow.

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Support 2D texture sub-source uploads from HTMLImageElement.

Covers both texImage2D and texSubImage2D.

Verified with new tests in https://github.com/KhronosGroup/WebGL/pull/2119 .

Other code paths will follow.

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/936bf933e5b57ed08bc8ff211233a21783260615
Cr-Commit-Position: refs/heads/master@{#428889}
==========

[commit-bot: I haz the power, 2016-11-01 00:56:44]

Patchset 3 (id:??) landed as
https://crrev.com/936bf933e5b57ed08bc8ff211233a21783260615
Cr-Commit-Position: refs/heads/master@{#428889}