third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h - Issue 2458943002: Support 2D texture sub-source uploads from HTMLImageElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

Issue 2458943002: Support 2D texture sub-source uploads from HTMLImageElement. (Closed)

Patch Set: Fixed bug in computation of default image sub-rectangle. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

index 941e23539cd8fbdd3921a3a18e637469c31cbdd9..f48b667825643520b216c9817da881bdbba64a44 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

@@ -1031,7 +1031,8 @@ class MODULES_EXPORT WebGLRenderingContextBase : public CanvasRenderingContext,

Image*,

WebGLImageConversion::ImageHtmlDomSource,

bool flipY,

- bool premultiplyAlpha);

+ bool premultiplyAlpha,

+ const IntRect&);

// Copy from the source directly to the texture via the gpu, without a

// read-back to system memory. Souce could be canvas or imageBitmap.

@@ -1501,6 +1502,7 @@ class MODULES_EXPORT WebGLRenderingContextBase : public CanvasRenderingContext,

GLint,

HTMLImageElement*,

+ const IntRect&,

ExceptionState&);

void texImageHelperHTMLCanvasElement(TexImageFunctionID,

GLenum,

@@ -1536,6 +1538,8 @@ class MODULES_EXPORT WebGLRenderingContextBase : public CanvasRenderingContext,

ImageBitmap*,

ExceptionState&);

static const char* getTexImageFunctionName(TexImageFunctionID);

+ IntRect sentinelEmptyRect();

+ IntRect safeGetImageSize(Image*);

private:

WebGLRenderingContextBase(HTMLCanvasElement*,