Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 245893006: Remove bookmark_model.h includes from places where it is not needed. (Closed)

Created:
6 years, 8 months ago by tfarina
Modified:
6 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org
Visibility:
Public.

Description

Remove bookmark_model.h includes from places where it is not needed. Those places just want to mess with BookmarkNode, so we can just include components/bookmarks/core/browser/bookmark_node.h instead. BUG=360643 TEST=chrome, unit_tests they both link R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/browser/bookmarks/bookmark_codec.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_storage.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tfarina
6 years, 8 months ago (2014-04-22 22:28:26 UTC) #1
sky
LGTM
6 years, 8 months ago (2014-04-22 23:36:54 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-23 01:36:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/245893006/1
6 years, 8 months ago (2014-04-23 01:36:57 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 02:43:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-23 02:43:34 UTC) #6
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-23 02:48:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/245893006/1
6 years, 8 months ago (2014-04-23 02:49:22 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 06:22:27 UTC) #9
Message was sent while issue was closed.
Change committed as 265555

Powered by Google App Engine
This is Rietveld 408576698