chromeos: Refactor NetworkConfigView to use shared widget parent code for mash

chromeos: Refactor NetworkConfigView to use shared widget parent code for mash

Now that SystemTrayClient::CreateUnhostedDialogWidget exists for both mash and
classic ash, convert NetworkConfigView to use it.

This exposes the fact that LoginDisplayHost::GetNativeWindow does not return a
valid mus window (aka ui::Window) parent. However, mash is converting soon to
use aura::Window natively, so that problem will go away. Also, if the user is
at a login screen then CreateUnhostedDialogWidget should do the right thing
anyway.

BUG=657021
TEST=open wifi password dialogs, both after and before login, on both mash and
classic ash

Committed: https://crrev.com/f3e88cbf92c8965319eef3a20e6073c8fe4bed6f
Cr-Commit-Position: refs/heads/master@{#428731}

[James Cook, 2016-10-28 00:07:22]

jamescook@chromium.org changed reviewers:
+ stevenjb@chromium.org

[James Cook, 2016-10-28 00:07:23]

stevenjb, please take a look.

[stevenjb, 2016-10-28 00:18:43]

Hooray for code evolution! Thanks for doing this.
We should make sure that connecting to a secure wifi network brings up the
dialog (and when logged in too), I'm not sure whether or not we have actual test
coverage for that...

LGTM

[stevenjb, 2016-10-28 00:20:37]

On 2016/10/28 00:18:43, stevenjb wrote:
> Hooray for code evolution! Thanks for doing this.
> We should make sure that connecting to a secure wifi network brings up the
> dialog (and when logged in too), I'm not sure whether or not we have actual
test
> coverage for that...
> 
> LGTM

P.S. You can test on Linux with chromeos=1 using wif2_PSK in the default list of
fake networks.

[James Cook, 2016-10-31 15:46:30]

Yep, I've been testing all these dialogs manually, either with Wi-Fi 2 or by
hacking the code to spawn them.

[James Cook, 2016-10-31 15:49:44]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 15:50:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-31 16:04:07]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2016-10-31 16:04:11]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-10-31 16:04:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2458883002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-31 16:04:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 16:22:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-31 16:45:45]

Description was changed from

==========
chromeos: Refactor NetworkConfigView to use shared widget parent code for mash

Now that SystemTrayClient::CreateUnhostedDialogWidget exists for both mash and
classic ash, convert NetworkConfigView to use it.

This exposes the fact that LoginDisplayHost::GetNativeWindow does not return a
valid mus window (aka ui::Window) parent. However, mash is converting soon to
use aura::Window natively, so that problem will go away. Also, if the user is
at a login screen then CreateUnhostedDialogWidget should do the right thing
anyway.

BUG=657021
TEST=open wifi password dialogs, both after and before login, on both mash and
classic ash
==========

to

==========
chromeos: Refactor NetworkConfigView to use shared widget parent code for mash

Now that SystemTrayClient::CreateUnhostedDialogWidget exists for both mash and
classic ash, convert NetworkConfigView to use it.

This exposes the fact that LoginDisplayHost::GetNativeWindow does not return a
valid mus window (aka ui::Window) parent. However, mash is converting soon to
use aura::Window natively, so that problem will go away. Also, if the user is
at a login screen then CreateUnhostedDialogWidget should do the right thing
anyway.

BUG=657021
TEST=open wifi password dialogs, both after and before login, on both mash and
classic ash

Committed: https://crrev.com/f3e88cbf92c8965319eef3a20e6073c8fe4bed6f
Cr-Commit-Position: refs/heads/master@{#428731}
==========

[commit-bot: I haz the power, 2016-10-31 16:45:46]

Patchset 2 (id:??) landed as
https://crrev.com/f3e88cbf92c8965319eef3a20e6073c8fe4bed6f
Cr-Commit-Position: refs/heads/master@{#428731}