chromeos: Refactor NetworkConfigView to use shared widget parent code for mash

chrome/browser/chromeos/options/network_config_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/options/network_config_view.h"
 
 #include <algorithm>
 
-#include "ash/public/cpp/shell_window_ids.h"
-#include "ash/shell.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chromeos/login/ui/login_display_host.h"
 #include "chrome/browser/chromeos/options/network_property_ui_data.h"
 #include "chrome/browser/chromeos/options/vpn_config_view.h"
 #include "chrome/browser/chromeos/options/wifi_config_view.h"
 #include "chrome/browser/chromeos/options/wimax_config_view.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/ash/ash_util.h"
+#include "chrome/browser/ui/ash/system_tray_client.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/grit/locale_settings.h"
 #include "chromeos/login/login_state.h"
 #include "chromeos/network/network_state.h"
 #include "chromeos/network/network_state_handler.h"
 #include "components/device_event_log/device_event_log.h"
 #include "components/user_manager/user.h"
-#include "services/ui/public/cpp/property_type_converters.h"
-#include "services/ui/public/interfaces/window_manager.mojom.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/aura/window_event_dispatcher.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/color_palette.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/paint_vector_icon.h"
 #include "ui/gfx/vector_icons_public.h"
 #include "ui/views/controls/button/md_text_button.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/layout/layout_constants.h"
 #include "ui/views/widget/widget.h"
 
 using views::Widget;
 
 namespace chromeos {
 
 namespace {
 
 // Used to check if a network config dialog is already showing.
 NetworkConfigView* g_instance = nullptr;
 
 gfx::NativeWindow GetParentForUnhostedDialog() {
   if (LoginDisplayHost::default_host()) {
-    return LoginDisplayHost::default_host()->GetNativeWindow();
+    // TODO(jamescook): LoginDisplayHost has the wrong native window in mash.
+    // This will fix itself when mash converts from ui::Window to aura::Window.
+    // http://crbug.com/659155
+    if (!chrome::IsRunningInMash())
+      return LoginDisplayHost::default_host()->GetNativeWindow();
   } else {
     Browser* browser = chrome::FindTabbedBrowser(
         ProfileManager::GetPrimaryUserProfile(), true);
     if (browser)
       return browser->window()->GetNativeWindow();
   }
   return nullptr;
 }
 
 }  // namespace
@@ skipping 37 matching lines @@
   }
   return child_config_view_ != nullptr;
 }
 
 NetworkConfigView::~NetworkConfigView() {
   DCHECK_EQ(g_instance, this);
   g_instance = nullptr;
 }
 
 // static
-void NetworkConfigView::ShowInParent(const std::string& network_id,
-                                     gfx::NativeWindow parent) {
-  DCHECK(parent);
-  NetworkConfigView* view = CreateForNetworkId(network_id);
-  if (view)
-    view->ShowDialog(parent);
-}
-
-// static
-void NetworkConfigView::ShowInContainer(const std::string& network_id,
-                                        int container_id) {
-  DCHECK_NE(container_id, ash::kShellWindowId_Invalid);
-  NetworkConfigView* view = CreateForNetworkId(network_id);
-  if (view)
-    view->ShowDialogInContainer(container_id);
-}
-
-// static
-NetworkConfigView* NetworkConfigView::CreateForNetworkId(
-    const std::string& network_id) {
+void NetworkConfigView::ShowForNetworkId(const std::string& network_id,
+                                         gfx::NativeWindow parent) {
   if (g_instance)
-    return nullptr;
+    return;
   const NetworkState* network =
       NetworkHandler::Get()->network_state_handler()->GetNetworkStateFromGuid(
           network_id);
   if (!network) {
     LOG(ERROR)
-        << "NetworkConfigView::CreateForNetworkId called with invalid network";
-    return nullptr;
+        << "NetworkConfigView::ShowForNetworkId called with invalid network";
+    return;
   }
   NetworkConfigView* view = new NetworkConfigView();
   if (!view->InitWithNetworkState(network)) {
-    LOG(ERROR) << "NetworkConfigView::CreateForNetworkId called with invalid "
+    LOG(ERROR) << "NetworkConfigView::ShowForNetworkId called with invalid "
                   "network type: "
                << network->type();
     delete view;
-    return nullptr;
+    return;
   }
-  NET_LOG(USER) << "NetworkConfigView::CreateForNetworkId: " << network->path();
-  return view;
+  NET_LOG(USER) << "NetworkConfigView::ShowForNetworkId: " << network->path();
+  view->ShowDialog(parent);
 }
 
 // static
 void NetworkConfigView::ShowForType(const std::string& type,
                                     gfx::NativeWindow parent) {
-  // |parent| may be null.
-  NetworkConfigView* view = CreateForType(type);
-  if (view)
-    view->ShowDialog(parent);
-}
-
-// static
-void NetworkConfigView::ShowForTypeInContainer(const std::string& type,
-                                               int container_id) {
-  DCHECK_NE(container_id, ash::kShellWindowId_Invalid);
-  NetworkConfigView* view = CreateForType(type);
-  if (view)
-    view->ShowDialogInContainer(container_id);
-}
-
-// static
-NetworkConfigView* NetworkConfigView::CreateForType(const std::string& type) {
   if (g_instance)
-    return nullptr;
+    return;
   NetworkConfigView* view = new NetworkConfigView();
   if (!view->InitWithType(type)) {
-    LOG(ERROR) << "NetworkConfigView::CreateForType called with invalid type: "
+    LOG(ERROR) << "NetworkConfigView::ShowForType called with invalid type: "
                << type;
     delete view;
-    return nullptr;
+    return;
   }
-  NET_LOG(USER) << "NetworkConfigView::CreateForType: " << type;
-  return view;
+  NET_LOG(USER) << "NetworkConfigView::ShowForType: " << type;
+  view->ShowDialog(parent);
 }
 
 gfx::NativeWindow NetworkConfigView::GetNativeWindow() const {
   return GetWidget()->GetNativeWindow();
 }
 
 base::string16 NetworkConfigView::GetDialogButtonLabel(
     ui::DialogButton button) const {
   if (button == ui::DIALOG_BUTTON_OK) {
     if (child_config_view_->IsConfigureDialog())
@@ skipping 101 matching lines @@
     const ViewHierarchyChangedDetails& details) {
   // Can't init before we're inserted into a Container, because we require
   // a HWND to parent native child controls to.
   views::DialogDelegateView::ViewHierarchyChanged(details);
   if (details.is_add && details.child == this) {
     AddChildView(child_config_view_);
   }
 }
 
 void NetworkConfigView::ShowDialog(gfx::NativeWindow parent) {
+  // Attempt to find a fallback parent window.
   if (parent == nullptr)
     parent = GetParentForUnhostedDialog();
-  // Failed connections may result in a pop-up with no natural parent window,
-  // so provide a fallback context on the primary display. This is necessary
-  // becase one of parent or context must be non nullptr.
-  gfx::NativeWindow context =
-      parent ? nullptr : ash::Shell::GetPrimaryRootWindow();
-  Widget* window = DialogDelegate::CreateDialogWidget(this, context, parent);
+
+  Widget* window = nullptr;
+  if (parent) {
+    // Create as a child of |parent|.
+    window = DialogDelegate::CreateDialogWidget(this, nullptr, parent);
+  } else {
+    // Fall back to default window container on primary display.
+    window = SystemTrayClient::CreateUnownedDialogWidget(this);
+  }
   window->SetAlwaysOnTop(true);
   window->Show();
 }
-
-void NetworkConfigView::ShowDialogInContainer(int container_id) {
-  DCHECK_NE(container_id, ash::kShellWindowId_Invalid);
-  Widget::InitParams params = DialogDelegate::GetDialogWidgetInitParams(
-      this, nullptr, nullptr, gfx::Rect());
-  Widget* window = new Widget;
-  if (chrome::IsRunningInMash()) {
-    using ui::mojom::WindowManager;
-    params.mus_properties[WindowManager::kInitialContainerId_Property] =
-        mojo::ConvertTo<std::vector<uint8_t>>(container_id);
-  } else {
-    params.parent = ash::Shell::GetContainer(ash::Shell::GetPrimaryRootWindow(),
-                                             container_id);
-  }
-  window->Init(params);
-  window->SetAlwaysOnTop(true);
-  window->Show();
-}
 
 // ChildNetworkConfigView
 
 ChildNetworkConfigView::ChildNetworkConfigView(
     NetworkConfigView* parent,
     const std::string& service_path)
     : parent_(parent),
       service_path_(service_path) {
 }
 
@@ skipping 29 matching lines @@
 }
 
 ControlledSettingIndicatorView::~ControlledSettingIndicatorView() {}
 
 gfx::Size ControlledSettingIndicatorView::GetPreferredSize() const {
   return (managed_ && visible()) ? image_view_->GetPreferredSize()
                                  : gfx::Size();
 }
 
 }  // namespace chromeos