Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2458773005: Untangle setComposingText() and commitText() (Closed)

Created:
4 years, 1 month ago by yabinh
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Untangel setComposingText() and commitText() Make ReplicaInputConnection#commitText() and ThreadedInputConnection#commitText() call InputMethodController::commitText() instead of InputMethodController::setComposition() when text is empty. BUG=660296 Committed: https://crrev.com/7c04b06d49b5554e9a24a32a4b964ca651212b34 Cr-Commit-Position: refs/heads/master@{#428310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
yabinh
changwan@, PTAL, thanks~
4 years, 1 month ago (2016-10-28 06:45:08 UTC) #5
Changwan Ryu
lgtm, thanks!
4 years, 1 month ago (2016-10-28 06:47:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458773005/1
4 years, 1 month ago (2016-10-28 06:59:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 07:41:27 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 07:43:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c04b06d49b5554e9a24a32a4b964ca651212b34
Cr-Commit-Position: refs/heads/master@{#428310}

Powered by Google App Engine
This is Rietveld 408576698