content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java - Issue 2458773005: Untangle setComposingText() and commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java

Issue 2458773005: Untangle setComposingText() and commitText() (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java

index 1c91bbbd42cf34fefa1fd342927fe3682d402681..0518d5209403053be1ac8aac79f3ade4a7359305 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java

@@ -210,7 +210,7 @@ public class ReplicaInputConnection

mPendingAccent = 0;

super.commitText(text, newCursorPosition);

updateSelectionIfRequired();

- return mImeAdapter.sendCompositionToNative(text, newCursorPosition, text.length() > 0, 0);

+ return mImeAdapter.sendCompositionToNative(text, newCursorPosition, true, 0);

}

/**

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java » ('j') | no next file with comments »