Failure to parse full hash metadata shouldn't discard the response

components/safe_browsing_db/v4_get_hash_protocol_manager.h

Index: components/safe_browsing_db/v4_get_hash_protocol_manager.h
diff --git a/components/safe_browsing_db/v4_get_hash_protocol_manager.h b/components/safe_browsing_db/v4_get_hash_protocol_manager.h
index fb736d905da5fe047256ef3855c4958c3401f923..94388cd4372d6c7f8ae66db8780ef1b130ffe43e 100644
--- a/components/safe_browsing_db/v4_get_hash_protocol_manager.h
+++ b/components/safe_browsing_db/v4_get_hash_protocol_manager.h
@@ -271,10 +271,10 @@ class V4GetHashProtocolManager : public net::URLFetcherDelegate,
                          std::vector<FullHashInfo>* full_hash_infos,
                          base::Time* negative_cache_expire);
 
-  // Parses the store specific |metadata| information from |match|. Returns
-  // true if the metadata information was parsed correctly and was consistent
-  // with what's expected from that corresponding store; false otherwise.
-  bool ParseMetadata(const ThreatMatch& match, ThreatMetadata* metadata);
+  // Parses the store specific |metadata| information from |match|. Records
+  // errors if the metadata information was not parsed correctly or was

[Nathan Parker, 2016/10/27 22:06:49]

nit: "Logs errors to UMA if the metadata..."

[vakh (use Gerrit instead), 2016/10/27 22:40:05]

Done.

+  // inconsistent with what's expected from that corresponding store.
+  static void ParseMetadata(const ThreatMatch& match, ThreatMetadata* metadata);
 
   // Resets the gethash error counter and multiplier.
   void ResetGetHashErrors();