Failure to parse full hash metadata shouldn't discard the response

components/safe_browsing_db/v4_get_hash_protocol_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SAFE_BROWSING_DB_V4_GET_HASH_PROTOCOL_MANAGER_H_
 #define COMPONENTS_SAFE_BROWSING_DB_V4_GET_HASH_PROTOCOL_MANAGER_H_
 
 // A class that implements Chrome's interface with the SafeBrowsing V4 protocol.
 //
 // The V4GetHashProtocolManager handles formatting and making requests of, and
@@ skipping 253 matching lines @@
 
   // Parses a FindFullHashesResponse protocol buffer and fills the results in
   // |full_hash_infos| and |negative_cache_expire|. |response_data| is a
   // serialized FindFullHashes protocol buffer. |negative_cache_expire| is the
   // cache expiry time of the hash prefixes that were requested. Returns true if
   // parsing is successful; false otherwise.
   bool ParseHashResponse(const std::string& response_data,
                          std::vector<FullHashInfo>* full_hash_infos,
                          base::Time* negative_cache_expire);
 
-  // Parses the store specific |metadata| information from |match|. Returns
-  // true if the metadata information was parsed correctly and was consistent
-  // with what's expected from that corresponding store; false otherwise.
-  bool ParseMetadata(const ThreatMatch& match, ThreatMetadata* metadata);
+  // Parses the store specific |metadata| information from |match|. Records
+  // errors if the metadata information was not parsed correctly or was

[Nathan Parker, 2016/10/27 22:06:49]

nit: "Logs errors to UMA if the metadata..."

[vakh (use Gerrit instead), 2016/10/27 22:40:05]

Done.

+  // inconsistent with what's expected from that corresponding store.
+  static void ParseMetadata(const ThreatMatch& match, ThreatMetadata* metadata);
 
   // Resets the gethash error counter and multiplier.
   void ResetGetHashErrors();
 
   // Overrides the clock used to check the time.
   void SetClockForTests(std::unique_ptr<base::Clock> clock);
 
   // Updates the state of the full hash cache upon receiving a valid response
   // from the server.
   void UpdateCache(const std::vector<HashPrefix>& prefixes_requested,
@@ skipping 68 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(V4GetHashProtocolManagerFactory);
 };
 
 #ifndef NDEBUG
 std::ostream& operator<<(std::ostream& os, const FullHashInfo& id);
 #endif
 
 }  // namespace safe_browsing
 
 #endif  // COMPONENTS_SAFE_BROWSING_DB_V4_GET_HASH_PROTOCOL_MANAGER_H_