[modules] Move MODULE variable back to Scopes, before resolution

[modules] Move MODULE variable back to Scopes, before resolution

Unlike other variable allocation logic, MODULE allocation does
not depend on resolution. So in order to give hole check elimination
(which runs during resolution) access to the information "is this
variable an import", simply allocate all modules variables prior
to resolution.

BUG=v8:1569
Committed: https://crrev.com/84bbdc7648926fc143529a04d15b57b8d1a6cb89
Cr-Commit-Position: refs/heads/master@{#40621}

[adamk, 2016-10-27 11:44:40]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 11:44:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-10-27 11:45:43]

adamk@chromium.org changed reviewers:
+ neis@chromium.org

[adamk, 2016-10-27 11:45:44]

Will see what the try jobs say, this looks a little funny.

[neis, 2016-10-27 12:06:04]

lgtm with nit

https://codereview.chromium.org/2458653002/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2458653002/diff/1/src/ast/scopes.cc#newcode1083
src/ast/scopes.cc:1083: // Module export variables must be allocated before
variable resolution
s/export //, or am I missing something?

Maybe also mention AccessNeedsHoleCheck explicitly.

[adamk, 2016-10-27 12:09:58]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-10-27 12:09:58]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2458653002/#ps20001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-10-27 12:09:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-10-27 12:10:01]

https://codereview.chromium.org/2458653002/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2458653002/diff/1/src/ast/scopes.cc#newcode1083
src/ast/scopes.cc:1083: // Module export variables must be allocated before
variable resolution
On 2016/10/27 12:06:04, neis wrote:
> s/export //, or am I missing something?
> 
> Maybe also mention AccessNeedsHoleCheck explicitly.

Done and done.

[commit-bot: I haz the power, 2016-10-27 12:37:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:15:32]

Description was changed from

==========
[modules] Move MODULE variable back to Scopes, before resolution

Unlike other variable allocation logic, MODULE allocation does
not depend on resolution. So in order to give hole check elimination
(which runs during resolution) access to the information "is this
variable an import", simply allocate all modules variables prior
to resolution.

BUG=v8:1569
==========

to

==========
[modules] Move MODULE variable back to Scopes, before resolution

Unlike other variable allocation logic, MODULE allocation does
not depend on resolution. So in order to give hole check elimination
(which runs during resolution) access to the information "is this
variable an import", simply allocate all modules variables prior
to resolution.

BUG=v8:1569

Committed: https://crrev.com/84bbdc7648926fc143529a04d15b57b8d1a6cb89
Cr-Commit-Position: refs/heads/master@{#40621}
==========

[commit-bot: I haz the power, 2016-11-17 22:15:33]

Patchset 2 (id:??) landed as
https://crrev.com/84bbdc7648926fc143529a04d15b57b8d1a6cb89
Cr-Commit-Position: refs/heads/master@{#40621}