Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: src/ast/scopes.h

Issue 2458653002: [modules] Move MODULE variable back to Scopes, before resolution (Closed)
Patch Set: Addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_AST_SCOPES_H_ 5 #ifndef V8_AST_SCOPES_H_
6 #define V8_AST_SCOPES_H_ 6 #define V8_AST_SCOPES_H_
7 7
8 #include "src/base/compiler-specific.h" 8 #include "src/base/compiler-specific.h"
9 #include "src/base/hashmap.h" 9 #include "src/base/hashmap.h"
10 #include "src/globals.h" 10 #include "src/globals.h"
(...skipping 844 matching lines...) Expand 10 before | Expand all | Expand 10 after
855 // particular, its module_requests map will be empty because we no longer need 855 // particular, its module_requests map will be empty because we no longer need
856 // the map after parsing. 856 // the map after parsing.
857 ModuleScope(Isolate* isolate, Handle<ScopeInfo> scope_info, 857 ModuleScope(Isolate* isolate, Handle<ScopeInfo> scope_info,
858 AstValueFactory* ast_value_factory); 858 AstValueFactory* ast_value_factory);
859 859
860 ModuleDescriptor* module() const { 860 ModuleDescriptor* module() const {
861 DCHECK_NOT_NULL(module_descriptor_); 861 DCHECK_NOT_NULL(module_descriptor_);
862 return module_descriptor_; 862 return module_descriptor_;
863 } 863 }
864 864
865 // Set MODULE as VariableLocation for all variables that will live in this 865 // Set MODULE as VariableLocation for all variables that will live in a
866 // module's export table. Imports are allocated by the parser. 866 // module's export table.
867 void AllocateModuleExports(); 867 void AllocateModuleVariables();
868 868
869 private: 869 private:
870 ModuleDescriptor* module_descriptor_; 870 ModuleDescriptor* module_descriptor_;
871 }; 871 };
872 872
873 } // namespace internal 873 } // namespace internal
874 } // namespace v8 874 } // namespace v8
875 875
876 #endif // V8_AST_SCOPES_H_ 876 #endif // V8_AST_SCOPES_H_
OLDNEW
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698