third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp - Issue 2458573002: bindings: Store ScriptState in generated callback functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp

Issue 2458573002: bindings: Store ScriptState in generated callback functions (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp

diff --git a/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp b/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp

index cbcd481b253580981fdb48a3f14d87da2c75f6e2..4a17fbd512dd53de5319459e036caea971b795af 100644

--- a/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp

+++ b/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp

@@ -150,7 +150,7 @@ TEST_F(RemotePlaybackTest, DisableRemotePlaybackCancelsAvailabilityCallbacks) {

MockFunction* callbackFunction = MockFunction::create(scope.getScriptState());

RemotePlaybackAvailabilityCallback* availabilityCallback =

- RemotePlaybackAvailabilityCallback::create(scope.isolate(),

+ RemotePlaybackAvailabilityCallback::create(scope.getScriptState(),

callbackFunction->bind());

// The initial call upon registering will not happen as it's posted on the

« no previous file with comments | « third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp ('k') | no next file » | no next file with comments »