third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp - Issue 2458573002: bindings: Store ScriptState in generated callback functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

Issue 2458573002: bindings: Store ScriptState in generated callback functions (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp ('k') | third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

diff --git a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

index 99e60193dbef92f3c56a153f8acefa0d8a7dd39f..2e71564369f4b86a19bf1135228dc53374b69c9e 100644

--- a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

+++ b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

@@ -202,7 +202,7 @@ void RemotePlayback::notifyInitialAvailability(int callbackId) {

if (iter == m_availabilityCallbacks.end())

return;

- iter->value->call(m_scriptState.get(), this, m_availability);

+ iter->value->call(this, m_availability);

}

void RemotePlayback::stateChanged(WebRemotePlaybackState state) {

@@ -243,7 +243,7 @@ void RemotePlayback::availabilityChanged(bool available) {

m_availability = available;

for (auto& callback : m_availabilityCallbacks.values())

- callback->call(m_scriptState.get(), this, m_availability);

+ callback->call(this, m_availability);

}

void RemotePlayback::promptCancelled() {