Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h

Issue 2458573002: bindings: Store ScriptState in generated callback functions (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h b/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h
index a153ca4787bb1e9a8aac6df626459ba3f6cbd5e3..6a59311a34565cacf80a106e0d4190939ce15f80 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h
+++ b/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h
@@ -22,9 +22,9 @@ class ScriptState;
class CORE_EXPORT VoidCallbackFunctionTypedef final : public GarbageCollectedFinalized<VoidCallbackFunctionTypedef>,
public TraceWrapperBase {
public:
- static VoidCallbackFunctionTypedef* create(v8::Isolate* isolate, v8::Local<v8::Function> callback)
+ static VoidCallbackFunctionTypedef* create(ScriptState* scriptState, v8::Local<v8::Function> callback)
{
- return new VoidCallbackFunctionTypedef(isolate, callback);
+ return new VoidCallbackFunctionTypedef(scriptState, callback);
}
~VoidCallbackFunctionTypedef() = default;
@@ -32,7 +32,7 @@ public:
DECLARE_TRACE();
DECLARE_TRACE_WRAPPERS();
- bool call(ScriptState* scriptState, ScriptWrappable* scriptWrappable, const String& arg);
+ bool call(ScriptWrappable* scriptWrappable, const String& arg);
v8::Local<v8::Function> v8Value(v8::Isolate* isolate)
{
@@ -46,7 +46,9 @@ public:
}
private:
- VoidCallbackFunctionTypedef(v8::Isolate* isolate, v8::Local<v8::Function>);
+ VoidCallbackFunctionTypedef(ScriptState*, v8::Local<v8::Function>);
+
+ RefPtr<ScriptState> m_scriptState;
ScopedPersistent<v8::Function> m_callback;
};

Powered by Google App Engine
This is Rietveld 408576698