Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp

Issue 2458573002: bindings: Store ScriptState in generated callback functions (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp b/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
index ff8a88d3be31f20f677efd3df4aa2a901562b693..c944a664daee78d3f5273b242700a9c3de1002e2 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
@@ -18,8 +18,9 @@
namespace blink {
-VoidCallbackFunctionInterfaceArg::VoidCallbackFunctionInterfaceArg(v8::Isolate* isolate, v8::Local<v8::Function> callback)
- : m_callback(isolate, callback)
+VoidCallbackFunctionInterfaceArg::VoidCallbackFunctionInterfaceArg(ScriptState* scriptState, v8::Local<v8::Function> callback)
+ : m_scriptState(scriptState),
+ m_callback(scriptState->isolate(), callback)
{
DCHECK(!m_callback.isEmpty());
m_callback.setPhantom();
@@ -34,12 +35,12 @@ DEFINE_TRACE_WRAPPERS(VoidCallbackFunctionInterfaceArg)
visitor->traceWrappers(&m_callback.cast<v8::Object>());
}
-bool VoidCallbackFunctionInterfaceArg::call(ScriptState* scriptState, ScriptWrappable* scriptWrappable, HTMLDivElement* divElement)
+bool VoidCallbackFunctionInterfaceArg::call(ScriptWrappable* scriptWrappable, HTMLDivElement* divElement)
{
- if (!scriptState->contextIsValid())
+ if (!m_scriptState->contextIsValid())
return false;
- ExecutionContext* context = scriptState->getExecutionContext();
+ ExecutionContext* context = m_scriptState->getExecutionContext();
DCHECK(context);
if (context->activeDOMObjectsAreSuspended() || context->activeDOMObjectsAreStopped())
return false;
@@ -50,19 +51,19 @@ bool VoidCallbackFunctionInterfaceArg::call(ScriptState* scriptState, ScriptWrap
// TODO(bashi): Make sure that using TrackExceptionState is OK.
// crbug.com/653769
TrackExceptionState exceptionState;
- ScriptState::Scope scope(scriptState);
+ ScriptState::Scope scope(m_scriptState.get());
- v8::Local<v8::Value> divElementArgument = toV8(divElement, scriptState->context()->Global(), scriptState->isolate());
+ v8::Local<v8::Value> divElementArgument = toV8(divElement, m_scriptState->context()->Global(), m_scriptState->isolate());
- v8::Local<v8::Value> thisValue = toV8(scriptWrappable, scriptState->context()->Global(), scriptState->isolate());
+ v8::Local<v8::Value> thisValue = toV8(scriptWrappable, m_scriptState->context()->Global(), m_scriptState->isolate());
v8::Local<v8::Value> argv[] = { divElementArgument };
v8::Local<v8::Value> v8ReturnValue;
- v8::TryCatch exceptionCatcher(scriptState->isolate());
+ v8::TryCatch exceptionCatcher(m_scriptState->isolate());
exceptionCatcher.SetVerbose(true);
- if (V8ScriptRunner::callFunction(m_callback.newLocal(scriptState->isolate()), scriptState->getExecutionContext(), thisValue, 1, argv, scriptState->isolate()).ToLocal(&v8ReturnValue))
+ if (V8ScriptRunner::callFunction(m_callback.newLocal(m_scriptState->isolate()), m_scriptState->getExecutionContext(), thisValue, 1, argv, m_scriptState->isolate()).ToLocal(&v8ReturnValue))
{
return true;
}

Powered by Google App Engine
This is Rietveld 408576698