Addressing C4267 warnings for printing.

printing/pdf_metafile_cg_mac.cc

Index: printing/pdf_metafile_cg_mac.cc
diff --git a/printing/pdf_metafile_cg_mac.cc b/printing/pdf_metafile_cg_mac.cc
index c9eb9df910b9cc51ae4451fa6d1b099cde080b12..96984939da184a85ba9f9606de8d0146d6ead315 100644
--- a/printing/pdf_metafile_cg_mac.cc
+++ b/printing/pdf_metafile_cg_mac.cc
@@ -87,13 +87,12 @@ bool PdfMetafileCg::Init() {
 }
 
 bool PdfMetafileCg::InitFromData(const void* src_buffer,
-                                 uint32_t src_buffer_size) {
+                                 size_t src_buffer_size) {
   DCHECK(!context_.get());
   DCHECK(!pdf_data_.get());
 
-  if (!src_buffer || src_buffer_size == 0) {
+  if (!src_buffer || !src_buffer_size)
     return false;
-  }
 
   pdf_data_.reset(CFDataCreateMutable(kCFAllocatorDefault, src_buffer_size));

[Will Harris, 2016/10/27 22:52:34]

is a CFIndex the same type as a size_t? I have no idea about cocoa types.

[Lei Zhang, 2016/10/27 23:15:14]

Neither do I, but I found
https://opensource.apple.com/source/CF/CF-476.14/CFBase.h which says:

typedef signed long CFIndex;

Shall I add another check here?

   CFDataAppendBytes(pdf_data_, static_cast<const UInt8*>(src_buffer),