Addressing C4267 warnings for printing.

printing/pdf_metafile_cg_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/pdf_metafile_cg_mac.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 
@@ skipping 69 matching lines @@
   context_.reset(CGPDFContextCreate(pdf_consumer, nullptr, nullptr));
   if (!context_.get()) {
     LOG(ERROR) << "Failed to create pdf context for metafile";
     pdf_data_.reset();
   }
 
   return true;
 }
 
 bool PdfMetafileCg::InitFromData(const void* src_buffer,
-                                 uint32_t src_buffer_size) {
+                                 size_t src_buffer_size) {
   DCHECK(!context_.get());
   DCHECK(!pdf_data_.get());
 
-  if (!src_buffer || src_buffer_size == 0) {
+  if (!src_buffer || !src_buffer_size)
     return false;
-  }
 
   pdf_data_.reset(CFDataCreateMutable(kCFAllocatorDefault, src_buffer_size));

[Will Harris, 2016/10/27 22:52:34]

is a CFIndex the same type as a size_t? I have no idea about cocoa types.

[Lei Zhang, 2016/10/27 23:15:14]

Neither do I, but I found
https://opensource.apple.com/source/CF/CF-476.14/CFBase.h which says:

typedef signed long CFIndex;

Shall I add another check here?

   CFDataAppendBytes(pdf_data_, static_cast<const UInt8*>(src_buffer),
                     src_buffer_size);
 
   return true;
 }
 
 void PdfMetafileCg::StartPage(const gfx::Size& page_size,
                               const gfx::Rect& content_area,
                               const float& scale_factor) {
   DCHECK(context_.get());
@@ skipping 180 matching lines @@
 
   if (!pdf_doc_.get()) {
     ScopedCFTypeRef<CGDataProviderRef> pdf_data_provider(
         CGDataProviderCreateWithCFData(pdf_data_));
     pdf_doc_.reset(CGPDFDocumentCreateWithProvider(pdf_data_provider));
   }
   return pdf_doc_.get();
 }
 
 }  // namespace printing