Addressing C4267 warnings for printing.

Addressing C4267 warnings for printing.

BUG=167187
Committed: https://crrev.com/6b4461fd74c452ab0f9d97cdf051e84053f23aa1
Cr-Commit-Position: refs/heads/master@{#428461}

[Lei Zhang, 2016-10-26 23:52:10]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 23:52:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 00:51:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 00:51:46]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Lei Zhang, 2016-10-27 05:42:02]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 05:42:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-10-27 06:05:16]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 06:05:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 07:44:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 07:44:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2016-10-27 21:07:34]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 21:08:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 22:36:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 22:36:25]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-10-27 22:40:23]

thestig@chromium.org changed reviewers:
+ halcanary@google.com, wfh@chromium.org

[Lei Zhang, 2016-10-27 22:40:24]

One more, but probably the last one for things I own in Chromium.

There's still PDFium as a whole, but that's a Herculean task.

[Will Harris, 2016-10-27 22:52:09]

This lgtm but I am not an expert on crazy cocoa types.

[Will Harris, 2016-10-27 22:52:34]

sorry I had a draft

https://codereview.chromium.org/2458513003/diff/60001/printing/pdf_metafile_c...
File printing/pdf_metafile_cg_mac.cc (right):

https://codereview.chromium.org/2458513003/diff/60001/printing/pdf_metafile_c...
printing/pdf_metafile_cg_mac.cc:97:
pdf_data_.reset(CFDataCreateMutable(kCFAllocatorDefault, src_buffer_size));
is a CFIndex the same type as a size_t? I have no idea about cocoa types.

[Lei Zhang, 2016-10-27 23:15:14]

https://codereview.chromium.org/2458513003/diff/60001/printing/pdf_metafile_c...
File printing/pdf_metafile_cg_mac.cc (right):

https://codereview.chromium.org/2458513003/diff/60001/printing/pdf_metafile_c...
printing/pdf_metafile_cg_mac.cc:97:
pdf_data_.reset(CFDataCreateMutable(kCFAllocatorDefault, src_buffer_size));
On 2016/10/27 22:52:34, Will Harris wrote:
> is a CFIndex the same type as a size_t? I have no idea about cocoa types.

Neither do I, but I found
https://opensource.apple.com/source/CF/CF-476.14/CFBase.h which says:

typedef signed long CFIndex;

Shall I add another check here?

[Will Harris, 2016-10-27 23:25:39]

On 2016/10/27 23:15:14, Lei Zhang wrote:
>
https://codereview.chromium.org/2458513003/diff/60001/printing/pdf_metafile_c...
> File printing/pdf_metafile_cg_mac.cc (right):
> 
>
https://codereview.chromium.org/2458513003/diff/60001/printing/pdf_metafile_c...
> printing/pdf_metafile_cg_mac.cc:97:
> pdf_data_.reset(CFDataCreateMutable(kCFAllocatorDefault, src_buffer_size));
> On 2016/10/27 22:52:34, Will Harris wrote:
> > is a CFIndex the same type as a size_t? I have no idea about cocoa types.
> 
> Neither do I, but I found
> https://opensource.apple.com/source/CF/CF-476.14/CFBase.h which says:
> 
> typedef signed long CFIndex;
> 
> Shall I add another check here?

Ya I found that too, but then if that was the case, I'm unsure how we wouldn't
be getting warnings from the compile... Maybe just add a
IsValueInRangeForNumericType<CFIndex>

[Lei Zhang, 2016-10-28 01:03:39]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 01:04:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 02:33:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 02:33:28]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Lei Zhang, 2016-10-28 02:40:32]

On 2016/10/27 23:25:39, Will Harris wrote:
> Ya I found that too, but then if that was the case, I'm unsure how we wouldn't
> be getting warnings from the compile... Maybe just add a
> IsValueInRangeForNumericType<CFIndex>

Patch set 5...

[Will Harris, 2016-10-28 03:16:51]

still seems lgtm to me. Thanks.

[Lei Zhang, 2016-10-28 04:32:22]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-10-28 04:32:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 06:01:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 06:01:29]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Lei Zhang, 2016-10-28 06:06:14]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-10-28 06:06:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 07:21:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 07:21:58]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Lei Zhang, 2016-10-28 08:09:40]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-10-28 08:09:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 09:32:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 09:32:47]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Lei Zhang, 2016-10-28 17:12:13]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-10-28 17:12:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 18:37:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 18:37:11]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Lei Zhang, 2016-10-28 18:46:44]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-10-28 18:47:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 19:34:57]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-28 19:56:01]

Description was changed from

==========
Addressing C4267 warnings for printing.

BUG=167187
==========

to

==========
Addressing C4267 warnings for printing.

BUG=167187

Committed: https://crrev.com/6b4461fd74c452ab0f9d97cdf051e84053f23aa1
Cr-Commit-Position: refs/heads/master@{#428461}
==========

[commit-bot: I haz the power, 2016-10-28 19:56:02]

Patchset 5 (id:??) landed as
https://crrev.com/6b4461fd74c452ab0f9d97cdf051e84053f23aa1
Cr-Commit-Position: refs/heads/master@{#428461}