Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

Issue 2458253002: [LayoutNG] Remove simple constructors from NGPhysicalConstraintSpace. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
index 30fc3021075eb433ab76089d080fee17b29e64d7..8b94f6f9805453c2cec0dd33f847e627308a555f 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
@@ -18,8 +18,13 @@ namespace {
NGConstraintSpace* ConstructConstraintSpace(NGWritingMode writing_mode,
NGDirection direction,
NGPhysicalSize size) {
- return new NGConstraintSpace(writing_mode, direction,
- new NGPhysicalConstraintSpace(size));
+ return new NGConstraintSpace(
+ writing_mode, direction,
+ new NGPhysicalConstraintSpace(
Gleb Lanbin 2016/10/31 16:33:56 may be it's time to introduce a builder for NGPhys
ikilpatrick 2016/10/31 17:00:03 Switched to builder here :)
+ size, /* fixed_width */ false, /* fixed_height */ false,
+ /* width_direction_triggers_scrollbar */ false,
+ /* height_direction_triggers_scrollbar */ false, FragmentNone,
+ FragmentColumn, /* is_new_fc */ false));
}
class NGBlockLayoutAlgorithmTest : public ::testing::Test {
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698