Issue 2458143002: Clear floats when we make a ruby base's children inline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2458143002: Clear floats when we make a ruby base's children inline (Closed)

Created:
4 years, 1 month ago by rhogan

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

Clear floats when we make a ruby base's children inline BUG=658584 Review-Url: https://codereview.chromium.org/2452993002 Cr-Commit-Position: refs/heads/master@{#427807} (cherry picked from commit 2578cf94297437a2e23b9a15cf5ba8c1f0b4becb) Committed: https://chromium.googlesource.com/chromium/src/+/8f9c2d54a055b4f126dffdbc4f2cc063efdb10a3

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -0 lines)			Patch
A	third_party/WebKit/LayoutTests/fast/block/float/rubybase-children-made-inline-crash.html	View	1 chunk	+41 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/fast/block/float/rubybase-children-made-inline-crash-expected.txt	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

rhogan

4 years, 1 month ago (2016-10-28 18:42:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8f9c2d54a055b4f126dffdbc4f2cc063efdb10a3.