Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2452993002: Clear floats when we make a ruby base's children inline (Closed)

Created:
4 years, 1 month ago by rhogan
Modified:
4 years, 1 month ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear floats when we make a ruby base's children inline BUG=658584 Committed: https://crrev.com/2578cf94297437a2e23b9a15cf5ba8c1f0b4becb Cr-Commit-Position: refs/heads/master@{#427807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/block/float/rubybase-children-made-inline-crash.html View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/block/float/rubybase-children-made-inline-crash-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
rhogan
4 years, 1 month ago (2016-10-26 15:10:08 UTC) #4
eae
Nice fix, thank you! LGTM
4 years, 1 month ago (2016-10-26 16:53:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452993002/1
4 years, 1 month ago (2016-10-26 21:17:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 21:28:39 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 21:31:16 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2578cf94297437a2e23b9a15cf5ba8c1f0b4becb
Cr-Commit-Position: refs/heads/master@{#427807}

Powered by Google App Engine
This is Rietveld 408576698