Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2458083002: ▶ Define separate variable for the sdk root used to load gmscore. (Closed)

Created:
4 years, 1 month ago by dgn
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Define separate variable for the sdk root used to load gmscore. BUG=624324 TBR=agrieve@chromium.org Committed: https://crrev.com/0ea787ad5d60a2bc91e15333d136da238b7ebf55 Cr-Commit-Position: refs/heads/master@{#428398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M build/config/android/config.gni View 1 chunk +7 lines, -0 lines 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
dgn
PTAL. ToT broke as it uses a different location for the sdk root, and the ...
4 years, 1 month ago (2016-10-28 15:12:39 UTC) #5
dgn
Bot logs: https://uberchromegw.corp.google.com/i/internal.client.clank_tot/builders/instrumentation-mako-clankium-tot/builds/10965/steps/generate_build_files/logs/stdio
4 years, 1 month ago (2016-10-28 15:13:53 UTC) #6
mlamouri (slow - plz ping)
lgtm
4 years, 1 month ago (2016-10-28 15:15:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458083002/1
4 years, 1 month ago (2016-10-28 16:11:21 UTC) #11
agrieve
On 2016/10/28 16:11:21, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 1 month ago (2016-10-28 16:55:05 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 17:06:35 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 17:21:59 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ea787ad5d60a2bc91e15333d136da238b7ebf55
Cr-Commit-Position: refs/heads/master@{#428398}

Powered by Google App Engine
This is Rietveld 408576698