build/secondary/third_party/android_tools/BUILD.gn - Issue 2458083002: ▶ Define separate variable for the sdk root used to load gmscore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/secondary/third_party/android_tools/BUILD.gn

Issue 2458083002: ▶ Define separate variable for the sdk root used to load gmscore. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/secondary/third_party/android_tools/BUILD.gn

diff --git a/build/secondary/third_party/android_tools/BUILD.gn b/build/secondary/third_party/android_tools/BUILD.gn

index a31f4cf37376b94a52e1335bb70666e56ced22ce..8fbf24f6e0ee3e1701d423a36859d8fb6b0cc69c 100644

--- a/build/secondary/third_party/android_tools/BUILD.gn

+++ b/build/secondary/third_party/android_tools/BUILD.gn

@@ -144,7 +144,7 @@ android_java_prebuilt("legacy_http_javalib") {

}

# TODO(dgn): Use the POM files instead of hardcoding the dependencies.

-gms_path = "$android_sdk_root/extras/google/m2repository/com/google/android/gms"

+gms_path = "$default_extras_android_sdk_root/extras/google/m2repository/com/google/android/gms"

gms_version = "9.8.0"

android_aar_prebuilt("google_play_services_basement_java") {

« no previous file with comments | « build/config/android/config.gni ('k') | no next file » | no next file with comments »