Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2458043002: Fix Password Manager Performance Issues (Closed)

Created:
4 years, 1 month ago by vabr (Chromium)
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Fix Password Manager Performance Issues This change further addresses the performance issue of password manager when many passwords are saved. Prior to this change a long password list (~1000 entries) can freeze the password manager for multiple seconds. Inspired by the edit dictionary settings (chrome://settings/editDictionary), this change removes the |autoExpands| attributes from the saved passwords and password exceptions lists and adds a CSS |max-height| attribute. This results in rendering the list almost instantaneously and keeps it responsive with regard to user interactions. BUG=651049 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2443143002 Cr-Commit-Position: refs/heads/master@{#427655} (cherry picked from commit 948349a43c3c3bd15a05c5b79e66507abfd31a3a) Committed: https://chromium.googlesource.com/chromium/src/+/a03793f62b38689b30939434ba7d9bbe1afdbdfe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/resources/options/password_manager.css View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/password_manager.js View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vabr (Chromium)
4 years, 1 month ago (2016-10-28 11:43:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a03793f62b38689b30939434ba7d9bbe1afdbdfe.

Powered by Google App Engine
This is Rietveld 408576698