Fix Password Manager Performance Issues

Fix Password Manager Performance Issues

This change further addresses the performance issue of password manager when
many passwords are saved. Prior to this change a long password list (~1000
entries) can freeze the password manager for multiple seconds.

Inspired by the edit dictionary settings (chrome://settings/editDictionary),
this change removes the |autoExpands| attributes from the saved passwords and
password exceptions lists and adds a CSS |max-height| attribute. This results in
rendering the list almost instantaneously and keeps it responsive with regard to
user interactions.

BUG=651049
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/948349a43c3c3bd15a05c5b79e66507abfd31a3a
Cr-Commit-Position: refs/heads/master@{#427655}

[jdoerrie, 2016-10-24 11:43:49]

Description was changed from

==========
Fix Password Manager Performance Issues

This change further addresses the performance issue of password manager when
many passwords are saved. Prior to this change a long password list (~1000
entries) can freeze the password manager for multiple seconds.

Inspired by the edit dictionary settings (chrome://settings/editDictionary),
this change removes the |autoExpands| attributes from the saved passwords and
password exceptions lists and adds a CSS |max-height| attribute. This results in
rendering the list almost instantaneously and keeps it responsive with regard to
user interactions.

BUG=651049
==========

to

==========
Fix Password Manager Performance Issues

This change further addresses the performance issue of password manager when
many passwords are saved. Prior to this change a long password list (~1000
entries) can freeze the password manager for multiple seconds.

Inspired by the edit dictionary settings (chrome://settings/editDictionary),
this change removes the |autoExpands| attributes from the saved passwords and
password exceptions lists and adds a CSS |max-height| attribute. This results in
rendering the list almost instantaneously and keeps it responsive with regard to
user interactions.

BUG=651049
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jdoerrie, 2016-10-24 11:46:50]

jdoerrie@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-10-25 00:50:17]

lgtm

https://codereview.chromium.org/2443143002/diff/1/chrome/browser/resources/op...
File chrome/browser/resources/options/password_manager.css (right):

https://codereview.chromium.org/2443143002/diff/1/chrome/browser/resources/op...
chrome/browser/resources/options/password_manager.css:35: }
nit: combine rules and add a comment

#saved-passwords-list,
#password-exceptions-list {
  max-height: 192px;  /* For performance (crbug.com/651049). */
}

[jdoerrie, 2016-10-26 08:53:51]

The CQ bit was checked by jdoerrie@chromium.org

[jdoerrie, 2016-10-26 08:53:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2443143002/#ps20001
(title: "Added min-height and comments")

[commit-bot: I haz the power, 2016-10-26 08:54:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 10:03:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-26 10:05:59]

Description was changed from

==========
Fix Password Manager Performance Issues

This change further addresses the performance issue of password manager when
many passwords are saved. Prior to this change a long password list (~1000
entries) can freeze the password manager for multiple seconds.

Inspired by the edit dictionary settings (chrome://settings/editDictionary),
this change removes the |autoExpands| attributes from the saved passwords and
password exceptions lists and adds a CSS |max-height| attribute. This results in
rendering the list almost instantaneously and keeps it responsive with regard to
user interactions.

BUG=651049
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix Password Manager Performance Issues

This change further addresses the performance issue of password manager when
many passwords are saved. Prior to this change a long password list (~1000
entries) can freeze the password manager for multiple seconds.

Inspired by the edit dictionary settings (chrome://settings/editDictionary),
this change removes the |autoExpands| attributes from the saved passwords and
password exceptions lists and adds a CSS |max-height| attribute. This results in
rendering the list almost instantaneously and keeps it responsive with regard to
user interactions.

BUG=651049
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/948349a43c3c3bd15a05c5b79e66507abfd31a3a
Cr-Commit-Position: refs/heads/master@{#427655}
==========

[commit-bot: I haz the power, 2016-10-26 10:05:59]

Patchset 2 (id:??) landed as
https://crrev.com/948349a43c3c3bd15a05c5b79e66507abfd31a3a
Cr-Commit-Position: refs/heads/master@{#427655}