Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(130)

Issue 2458023002: [css-grid] Fix percentage height resolution on replaced elements (Closed)

Created:
3 years, 8 months ago by Manuel Rego
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, jchaffraix+rendering, blink-reviews, eae+blinkwatch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Fix percentage height resolution on replaced elements More fixes on percentage heights for replaced elements. The problem now was when you have a replaced element inside a grid item, and both the replaced and the item have a percentage height. The item has a definite height as its percentage can be resolved against its grid area. So the replaced element percentage should be resolved against the height of the item. Current code was getting confused about this particular case, now we reuse hasDefiniteLogicalHeight() to detect it properly. Added new case to existent test. BUG=624716 TEST=fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html Committed: https://crrev.com/c4dc5e50ffa3ca4bef23a105ae8dc8304926b312 Cr-Commit-Position: refs/heads/master@{#428512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html View 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 3 chunks +7 lines, -17 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Manuel Rego
3 years, 8 months ago (2016-10-28 07:43:10 UTC) #2
jfernandez
lgtm
3 years, 8 months ago (2016-10-28 08:03:43 UTC) #3
jfernandez
Although better having @cbiesinger feedback, since he reviewed the other patches for percentage resolution.
3 years, 8 months ago (2016-10-28 08:13:07 UTC) #4
cbiesinger
> now we reuse hasAutoHeightOrContainingBlockWithAutoHeight() I think you mean hasDefiniteLogicalHeight()? Could you update the description? ...
3 years, 8 months ago (2016-10-28 19:28:24 UTC) #5
Manuel Rego
On 2016/10/28 19:28:24, cbiesinger wrote: > > now we reuse hasAutoHeightOrContainingBlockWithAutoHeight() > > I think ...
3 years, 8 months ago (2016-10-28 20:56:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458023002/1
3 years, 8 months ago (2016-10-28 20:57:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 8 months ago (2016-10-28 22:08:38 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2016-10-28 22:12:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4dc5e50ffa3ca4bef23a105ae8dc8304926b312
Cr-Commit-Position: refs/heads/master@{#428512}

Powered by Google App Engine
This is Rietveld 408576698