[css-grid] Fix percentage height resolution on replaced elements

[css-grid] Fix percentage height resolution on replaced elements

More fixes on percentage heights for replaced elements.
The problem now was when you have a replaced element inside a grid item,
and both the replaced and the item have a percentage height.

The item has a definite height as its percentage can be resolved
against its grid area. So the replaced element percentage should be
resolved against the height of the item.

Current code was getting confused about this particular case,
now we reuse hasDefiniteLogicalHeight() to detect it properly.

Added new case to existent test.

BUG=624716
TEST=fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html

Committed: https://crrev.com/c4dc5e50ffa3ca4bef23a105ae8dc8304926b312
Cr-Commit-Position: refs/heads/master@{#428512}

[Manuel Rego, 2016-10-28 07:43:10]

rego@igalia.com changed reviewers:
+ cbiesinger@chromium.org, jfernandez@igalia.com, svillar@igalia.com

[jfernandez, 2016-10-28 08:03:43]

lgtm

[jfernandez, 2016-10-28 08:13:07]

Although better having @cbiesinger feedback, since he reviewed the other patches
for percentage resolution.

[cbiesinger, 2016-10-28 19:28:24]

> now we reuse hasAutoHeightOrContainingBlockWithAutoHeight()

I think you mean hasDefiniteLogicalHeight()? Could you update the description?

lgtm otherwise.

[Manuel Rego, 2016-10-28 20:56:08]

Description was changed from

==========
[css-grid] Fix percentage height resolution on replaced elements

More fixes on percentage heights for replaced elements.
The problem now was when you have a replaced element inside a grid item,
and both the replaced and the item have a percentage height.

The item has a definite height as its percentage can be resolved
against its grid area. So the replaced element percentage should be
resolved against the height of the item.

Current code was getting confused about this particular case,
now we reuse hasAutoHeightOrContainingBlockWithAutoHeight()
to detect it properly.

Added new case to existent test.

BUG=624716
TEST=fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html
==========

to

==========
[css-grid] Fix percentage height resolution on replaced elements

More fixes on percentage heights for replaced elements.
The problem now was when you have a replaced element inside a grid item,
and both the replaced and the item have a percentage height.

The item has a definite height as its percentage can be resolved
against its grid area. So the replaced element percentage should be
resolved against the height of the item.

Current code was getting confused about this particular case,
now we reuse hasDefiniteLogicalHeight()
to detect it properly.

Added new case to existent test.

BUG=624716
TEST=fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html
==========

[Manuel Rego, 2016-10-28 20:56:28]

Description was changed from

==========
[css-grid] Fix percentage height resolution on replaced elements

More fixes on percentage heights for replaced elements.
The problem now was when you have a replaced element inside a grid item,
and both the replaced and the item have a percentage height.

The item has a definite height as its percentage can be resolved
against its grid area. So the replaced element percentage should be
resolved against the height of the item.

Current code was getting confused about this particular case,
now we reuse hasDefiniteLogicalHeight()
to detect it properly.

Added new case to existent test.

BUG=624716
TEST=fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html
==========

to

==========
[css-grid] Fix percentage height resolution on replaced elements

More fixes on percentage heights for replaced elements.
The problem now was when you have a replaced element inside a grid item,
and both the replaced and the item have a percentage height.

The item has a definite height as its percentage can be resolved
against its grid area. So the replaced element percentage should be
resolved against the height of the item.

Current code was getting confused about this particular case,
now we reuse hasDefiniteLogicalHeight() to detect it properly.

Added new case to existent test.

BUG=624716
TEST=fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html
==========

[Manuel Rego, 2016-10-28 20:56:49]

On 2016/10/28 19:28:24, cbiesinger wrote:
> > now we reuse hasAutoHeightOrContainingBlockWithAutoHeight()
> 
> I think you mean hasDefiniteLogicalHeight()? Could you update the description?

Sure this was a wrong copy&paste. Fixed.

[Manuel Rego, 2016-10-28 20:56:54]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2016-10-28 20:57:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 22:08:37]

Description was changed from

==========
[css-grid] Fix percentage height resolution on replaced elements

More fixes on percentage heights for replaced elements.
The problem now was when you have a replaced element inside a grid item,
and both the replaced and the item have a percentage height.

The item has a definite height as its percentage can be resolved
against its grid area. So the replaced element percentage should be
resolved against the height of the item.

Current code was getting confused about this particular case,
now we reuse hasDefiniteLogicalHeight() to detect it properly.

Added new case to existent test.

BUG=624716
TEST=fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html
==========

to

==========
[css-grid] Fix percentage height resolution on replaced elements

More fixes on percentage heights for replaced elements.
The problem now was when you have a replaced element inside a grid item,
and both the replaced and the item have a percentage height.

The item has a definite height as its percentage can be resolved
against its grid area. So the replaced element percentage should be
resolved against the height of the item.

Current code was getting confused about this particular case,
now we reuse hasDefiniteLogicalHeight() to detect it properly.

Added new case to existent test.

BUG=624716
TEST=fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html
==========

[commit-bot: I haz the power, 2016-10-28 22:08:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-28 22:12:45]

Description was changed from

==========
[css-grid] Fix percentage height resolution on replaced elements

More fixes on percentage heights for replaced elements.
The problem now was when you have a replaced element inside a grid item,
and both the replaced and the item have a percentage height.

The item has a definite height as its percentage can be resolved
against its grid area. So the replaced element percentage should be
resolved against the height of the item.

Current code was getting confused about this particular case,
now we reuse hasDefiniteLogicalHeight() to detect it properly.

Added new case to existent test.

BUG=624716
TEST=fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html
==========

to

==========
[css-grid] Fix percentage height resolution on replaced elements

More fixes on percentage heights for replaced elements.
The problem now was when you have a replaced element inside a grid item,
and both the replaced and the item have a percentage height.

The item has a definite height as its percentage can be resolved
against its grid area. So the replaced element percentage should be
resolved against the height of the item.

Current code was getting confused about this particular case,
now we reuse hasDefiniteLogicalHeight() to detect it properly.

Added new case to existent test.

BUG=624716
TEST=fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html

Committed: https://crrev.com/c4dc5e50ffa3ca4bef23a105ae8dc8304926b312
Cr-Commit-Position: refs/heads/master@{#428512}
==========

[commit-bot: I haz the power, 2016-10-28 22:12:46]

Patchset 1 (id:??) landed as
https://crrev.com/c4dc5e50ffa3ca4bef23a105ae8dc8304926b312
Cr-Commit-Position: refs/heads/master@{#428512}