Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html

Issue 2458023002: [css-grid] Fix percentage height resolution on replaced elements (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html
index 93f1700979b0f54aa1c05221ad67c9383908cd5c..ff0a18a7cf6be5e046541a7596ef10d6011c0e37 100644
--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html
@@ -18,6 +18,10 @@
height: 100%;
display: block;
}
+
+ .height100 {
+ height: 100%;
+ }
</style>
<script src="../../resources/testharness.js"></script>
@@ -70,4 +74,14 @@ as it's not stretched the grid item's height is indefinite, so the percentage ca
</div>
</div>
+<p>5) 100% height on the image (grid item's child) should be resolved against the height of the grid item,
+which also has a 100% height that is resolved against the height of the grid area (200px).</p>
+
+<div class="grid red">
+ <div class="height100" data-expected-width="200" data-expected-height="200">
+ <img src="../css/resources/greenbox-100px.png"
+ data-expected-width="200" data-expected-height="200">
+ </div>
+</div>
+
</body>
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698