Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2457903002: Disable ShelfViewVisibleBoundsTest flaky tests (Closed)

Created:
4 years, 1 month ago by mohsen
Modified:
4 years, 1 month ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, tdanderson
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ShelfViewVisibleBoundsTest flaky tests Temporarily disable flaky tests in ShelfViewVisibleBoundsTest, until the fix for issue 634128 lands which hopefully fixes this flake, too. BUG=625671, 619344 Committed: https://crrev.com/3b74d0d9f84a249083ff6541bf478d18a7bd8dee Cr-Commit-Position: refs/heads/master@{#428141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M ash/shelf/shelf_view_unittest.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
mohsen
Please take a look...
4 years, 1 month ago (2016-10-27 20:21:47 UTC) #4
James Cook
LGTM
4 years, 1 month ago (2016-10-27 21:00:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457903002/1
4 years, 1 month ago (2016-10-27 21:08:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 21:23:43 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 21:26:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b74d0d9f84a249083ff6541bf478d18a7bd8dee
Cr-Commit-Position: refs/heads/master@{#428141}

Powered by Google App Engine
This is Rietveld 408576698