Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2141)

Unified Diff: ash/shelf/shelf_view_unittest.cc

Issue 2457903002: Disable ShelfViewVisibleBoundsTest flaky tests (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_view_unittest.cc
diff --git a/ash/shelf/shelf_view_unittest.cc b/ash/shelf/shelf_view_unittest.cc
index 0051b29f7d54d26a4462ea8581e3e4009ac98037..6e93460575719592153e0ebe7c1964cd57545965 100644
--- a/ash/shelf/shelf_view_unittest.cc
+++ b/ash/shelf/shelf_view_unittest.cc
@@ -1957,7 +1957,14 @@ TEST_P(ShelfViewVisibleBoundsTest, ItemsAreInBounds) {
}
INSTANTIATE_TEST_CASE_P(LtrRtl, ShelfViewTextDirectionTest, testing::Bool());
-INSTANTIATE_TEST_CASE_P(VisibleBounds,
+
+// This test seems to be flaky with material design shelf (see
+// https://crbug.com/625671) and even in non-material mode (see
+// https://crbug.com/619344 which is fixed using a hack). Disabling for now.
+// TODO(mohsen): Hopefully, the fix for https://crbug.com/634128 that fixes
+// issues with shelf spacing, will fix this flake, too. Re-enable when that
+// issue is fixed.
+INSTANTIATE_TEST_CASE_P(DISABLED_VisibleBounds,
ShelfViewVisibleBoundsTest,
testing::Bool());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698