Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(29)

Issue 2457813002: Update and fix some markdown docs (Closed)

Created:
2 years, 10 months ago by Sam Clegg
Modified:
2 years, 10 months ago
Reviewers:
bradnelson
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -116 lines) Patch
M docs/build_systems.md View 3 chunks +19 lines, -14 lines 0 comments Download
M docs/chromium_integration.md View 1 1 chunk +3 lines, -3 lines 0 comments Download
D docs/gyp_build.md View 1 chunk +0 lines, -24 lines 0 comments Download
M docs/native_client_in_google_chrome.md View 3 chunks +27 lines, -33 lines 0 comments Download
M docs/source.md View 2 chunks +35 lines, -42 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Sam Clegg
2 years, 10 months ago (2016-10-27 17:14:22 UTC) #2
bradnelson
lgtm https://codereview.chromium.org/2457813002/diff/1/docs/chromium_integration.md File docs/chromium_integration.md (right): https://codereview.chromium.org/2457813002/diff/1/docs/chromium_integration.md#newcode19 docs/chromium_integration.md:19: the Chromium executable. (The Gyp build also has ...
2 years, 10 months ago (2016-10-28 14:43:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457813002/20001
2 years, 10 months ago (2016-10-28 16:16:57 UTC) #10
commit-bot: I haz the power
2 years, 10 months ago (2016-10-28 17:01:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/native_client/src/native_client/+/c1a895441...

Powered by Google App Engine
This is Rietveld 408576698