Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 ## Design documents | 1 ## Design documents |
| 2 | 2 |
| 3 * [Chromium integration for Win32, Linux and Mac] | 3 * [Chromium integration for Win32, Linux and Mac] |
| 4 (http://docs.google.com/View?id=dhhbw89r_0c7w4rxdc) | 4 (http://docs.google.com/View?id=dhhbw89r_0c7w4rxdc) |
| 5 * [Chromium integration for Win64] | 5 * [Chromium integration for Win64] |
| 6 (http://docs.google.com/View?id=dhhbw89r_2p9wgf5tg) | 6 (http://docs.google.com/View?id=dhhbw89r_2p9wgf5tg) |
| 7 | 7 |
| 8 ## Build system | 8 ## Build system |
| 9 | 9 |
| 10 Most of NaCl, including the trusted runtime and tests, is built using Scons. | 10 Most of NaCl, including the trusted runtime and tests, is built using Scons. |
| 11 However, Chromium ignores NaCl's Scons build system and uses Gyp to build NaCl | 11 However, Chromium ignores NaCl's Scons build system and uses gn to build NaCl |
| 12 (in the same way as it ignores Webkit's own build system). This is why there are | 12 (in the same way as it ignores Webkit's own build system). This is why there are |
| 13 `*.gyp` and `*.gypi` files in the NaCl tree, though the NaCl standalone build | 13 `*.gn` and `*.gni` files in the NaCl tree, though the NaCl standalone build |
| 14 doesn't use them. These Gyp files cover NaCl's trusted code but not tests. | 14 doesn't use them. These Gyp files cover NaCl's trusted code but not tests. |
| 15 | 15 |
| 16 ## sel\_ldr | 16 ## sel\_ldr |
| 17 | 17 |
| 18 On some systems, the code that is normally in sel\_ldr is statically linked into | 18 On some systems, the code that is normally in sel\_ldr is statically linked into |
| 19 the Chromium executable. (The Gyp build also has a target to build a standalone | 19 the Chromium executable. (The Gyp build also has a target to build a standalone |
|
bradnelson
2016/10/28 14:43:28
Change this too?
| |
| 20 sel\_ldr, but this is mainly for testing purposes.) | 20 sel\_ldr, but this is mainly for testing purposes.) |
| 21 | 21 |
| 22 Linking sel\_ldr into Chromium has some advantages: * It reduces version skew | 22 Linking sel\_ldr into Chromium has some advantages: * It reduces version skew |
| 23 issues. * It makes it easier to run sel\_ldr inside the sandbox. On Linux, | 23 issues. * It makes it easier to run sel\_ldr inside the sandbox. On Linux, |
| 24 sel\_ldr can be launched by forking Chromium's Zygote process, which is already | 24 sel\_ldr can be launched by forking Chromium's Zygote process, which is already |
| 25 set up to be sandboxed. This can also reduce per-instance startup costs a | 25 set up to be sandboxed. This can also reduce per-instance startup costs a |
| 26 little. * It makes it easier for sel\_ldr to link to Chromium-specific code | 26 little. * It makes it easier for sel\_ldr to link to Chromium-specific code |
| 27 (e.g. code specific to the Chromium Linux sandbox). | 27 (e.g. code specific to the Chromium Linux sandbox). |
| 28 | 28 |
| 29 However, there also some good reasons to build sel\_ldr as a separate | 29 However, there also some good reasons to build sel\_ldr as a separate |
| (...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 61 ## Policy on dependencies | 61 ## Policy on dependencies |
| 62 | 62 |
| 63 Native Client should not #include files from the "chrome" directory in the | 63 Native Client should not #include files from the "chrome" directory in the |
| 64 Chromium source tree. However, #including files from other directories (such as | 64 Chromium source tree. However, #including files from other directories (such as |
| 65 "base") might be OK. For some background, see [issue 469] | 65 "base") might be OK. For some background, see [issue 469] |
| 66 (http://code.google.com/p/nativeclient/issues/detail?id=469). | 66 (http://code.google.com/p/nativeclient/issues/detail?id=469). |
| 67 | 67 |
| 68 ## See also | 68 ## See also |
| 69 | 69 |
| 70 * GypBuild | 70 * GypBuild |
| OLD | NEW |