Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 2457683002: Revert of Turn on Analytic AA in Chrome take 2 (Closed)

Created:
4 years, 1 month ago by alancutter (OOO until 2018)
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Turn on Analytic AA in Chrome take 2 This change is a manual revert of the first revert attempt 7fec161fa71c3f0d694398de1d40aa8d6599a7c3 and the breaking change a947a329b3030259fbd042458dd6f31b1fe79dcf. Reason for revert: Broke many tests on many builders, see description in https://codereview.chromium.org/2447013005 Original issue's description: > Turn on Analytic AA in Chrome > > Update cc_unittests png files to reflect our changes. > > We also downgraded some ref tests to pixel tests because > there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the > circle boundaries. This seems to be reasonable as the test html usually > has more layers than the ref html. In the future, we may set a > configurable threshold for ref tests so we don't have to downgrade ref > tests for this reason. > > > BUG= > > patch from issue 2407393003 at patchset 20001 (http://crrev.com/2407393003#ps20001) > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > R=ajuma@chromium.org, fmalita@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/a947a329b3030259fbd042458dd6f31b1fe79dcf TBR=ajuma@google.com,ajuma@chromium.org,jam@google.com,jam@chromium.org,fmalita@chromium.org,reed@google.com,liyuqian@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=659909 Committed: https://chromium.googlesource.com/chromium/src/+/54c1292da30259bafbfe65c4a7e3039d0adb565b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A this_is_a_placeholder_rietveld_issue View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b Cr-Commit-Position: refs/heads/master@{#427957}
4 years, 1 month ago (2016-10-27 07:49:18 UTC) #2
alancutter (OOO until 2018)
4 years, 1 month ago (2016-10-27 07:51:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
54c1292da30259bafbfe65c4a7e3039d0adb565b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698