Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2447013005: Revert of Turn on Analytic AA in Chrome (Closed)

Created:
4 years, 1 month ago by alancutter (OOO until 2018)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, cc-bugs_chromium.org, dcheng, mtklein, djsollen, msarett
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Turn on Analytic AA in Chrome (patchset #1 id:1 of https://codereview.chromium.org/2458433002/ ) Reason for revert: Broke many tests [1] on many builders [2] [1] css1/basic/containment.html css1/box_properties/border_inline.html css1/box_properties/border_width.html css1/box_properties/margin_bottom_inline.html css1/box_properties/padding_right.html css1/classification/list_style_position.html css1/color_and_background/color.html css1/text_properties/text_align.html css1/text_properties/text_transform.html css3/filters/effect-reference-subregion.html css3/images/cross-fade-svg-size-diff.html css3/images/cross-fade-svg-size.html css3/masking/mask-luminance-svg.html fast/backgrounds/background-leakage-transforms.html fast/backgrounds/border-radius-split-background-image.html fast/backgrounds/border-radius-split-background.html fast/borders/border-radius-mask-canvas-with-shadow.html fast/borders/border-styles-split.html fast/box-shadow/spread.html fast/css/shadow-multiple.html fast/forms/calendar-picker/calendar-picker-appearance-ar.html fast/forms/calendar-picker/calendar-picker-appearance-minimum-date.html fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html fast/forms/calendar-picker/calendar-picker-appearance-required.html fast/forms/calendar-picker/calendar-picker-appearance-ru.html fast/forms/calendar-picker/calendar-picker-appearance-step.html fast/forms/calendar-picker/calendar-picker-appearance-zoom125.html fast/forms/calendar-picker/calendar-picker-appearance-zoom200.html fast/forms/calendar-picker/calendar-picker-appearance.html fast/forms/calendar-picker/month-picker-appearance-step.html fast/forms/calendar-picker/month-picker-appearance.html fast/forms/calendar-picker/week-picker-appearance-step.html fast/forms/calendar-picker/week-picker-appearance.html fast/forms/datalist/input-appearance-range-with-datalist-zoomed.html fast/forms/datalist/input-appearance-range-with-transform.html fast/forms/select/menulist-appearance-basic.html fast/forms/select/menulist-appearance-rtl.html fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom125.html fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom200.html fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew.html fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar.html fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance.html fast/images/color-profile-border-fade.html fast/images/color-profile-border-radius.html fast/images/color-profile-group.html fast/images/color-profile-iframe.html fast/images/color-profile-image-shape.html fast/images/color-profile-mask-image-svg.html fast/images/color-profile-svg-foreign-object.html fast/layers/overflow-hidden-rounded-corners-occlusion.html fast/writing-mode/border-styles-vertical-lr.html fast/writing-mode/border-styles-vertical-rl.html fast/writing-mode/box-shadow-vertical-lr.html fast/writing-mode/box-shadow-vertical-rl.html http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-align-self-baseline-vert-001.html imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-empty-001b.html svg/canvas/canvas-default-object-sizing.html svg/wicd/test-scalable-background-image1.xhtml svg/wicd/test-scalable-background-image2.xhtml tables/mozilla_expected_failures/marvin/backgr_fixed-bg.html virtual/android/fullscreen/full-screen-iframe-allowed-video.html virtual/android/fullscreen/video-controls-timeline.html virtual/display_list_2d_canvas/fast/canvas/canvas-arc-circumference-fill.html virtual/display_list_2d_canvas/fast/canvas/canvas-composite-transformclip.html virtual/display_list_2d_canvas/fast/canvas/canvas-composite.html virtual/display_list_2d_canvas/fast/canvas/canvas-ellipse-circumference-fill.html virtual/display_list_2d_canvas/fast/canvas/canvas-imageSmoothingEnabled-patterns.html virtual/display_list_2d_canvas/fast/canvas/canvas-incremental-repaint.html virtual/display_list_2d_canvas/fast/canvas/canvas-lost-gpu-context.html virtual/display_list_2d_canvas/fast/canvas/canvas-text-baseline-tiny-fonts.html virtual/display_list_2d_canvas/fast/canvas/image-object-in-canvas.html virtual/display_list_2d_canvas/fast/canvas/setWidthResetAfterForcedRender.html virtual/gpu/fast/canvas/canvas-lost-gpu-context.html virtual/gpu/fast/canvas/setWidthResetAfterForcedRender.html virtual/prefer_compositing_to_lcd_text/compositing/overflow/nested-border-radius-clipping.html virtual/scalefactor150/fast/hidpi/static/calendar-picker-appearance.html virtual/scalefactor150/fast/hidpi/static/data-suggestion-picker-appearance.html virtual/scalefactor200/fast/hidpi/static/calendar-picker-appearance.html virtual/scalefactor200/fast/hidpi/static/data-suggestion-picker-appearance.html virtual/scalefactor200withzoom/fast/hidpi/static/calendar-picker-appearance.html virtual/scalefactor200withzoom/fast/hidpi/static/data-suggestion-picker-appearance.html virtual/spv2/svg/custom/object-sizing-explicit-height.xhtml virtual/threaded/inspector/tracing/anonymous-image-object.html virtual/threaded/inspector/tracing/console-timeline.html virtual/threaded/inspector/tracing/decode-resize.html virtual/threaded/inspector/tracing/frame-model-instrumentation.html virtual/threaded/inspector/tracing/hit-test.html virtual/threaded/inspector/tracing/idle-callback.html virtual/threaded/inspector/tracing/scroll-invalidations.html virtual/threaded/inspector/tracing/timeline-js/compile-script.html virtual/threaded/inspector/tracing/timeline-js/timeline-gc-event.html virtual/threaded/inspector/tracing/timeline-js/timeline-injected-script-eval.html virtual/threaded/inspector/tracing/timeline-js/timeline-microtasks.html virtual/threaded/inspector/tracing/timeline-js/timeline-script-id.html virtual/threaded/inspector/tracing/timeline-js/timeline-script-tag-1.html virtual/threaded/inspector/tracing/timeline-js/timeline-script-tag-2.html virtual/threaded/inspector/tracing/timeline-layout/timeline-layout-reason.html virtual/threaded/inspector/tracing/timeline-layout/timeline-layout-with-invalidations.html virtual/threaded/inspector/tracing/timeline-layout/timeline-layout.html virtual/threaded/inspector/tracing/timeline-misc/timeline-animation-frame.html virtual/threaded/inspector/tracing/timeline-misc/timeline-auto-record.html virtual/threaded/inspector/tracing/timeline-misc/timeline-bound-function.html virtual/threaded/inspector/tracing/timeline-misc/timeline-event-causes.html virtual/threaded/inspector/tracing/timeline-misc/timeline-event-dispatch.html virtual/threaded/inspector/tracing/timeline-misc/timeline-grouped-invalidations.html virtual/threaded/inspector/tracing/timeline-misc/timeline-load-event.html virtual/threaded/inspector/tracing/timeline-misc/timeline-mark-timeline.html virtual/threaded/inspector/tracing/timeline-misc/timeline-node-reference.html virtual/threaded/inspector/tracing/timeline-misc/timeline-parse-html.html virtual/threaded/inspector/tracing/timeline-misc/timeline-receive-response-event.html virtual/threaded/inspector/tracing/timeline-misc/timeline-trivial.html virtual/threaded/inspector/tracing/timeline-paint/paint-profiler-update.html virtual/threaded/inspector/tracing/timeline-paint/timeline-paint-and-multiple-style-invalidations.html virtual/threaded/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node.html virtual/threaded/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations.html virtual/threaded/inspector/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations.html virtual/threaded/inspector/tracing/timeline-paint/timeline-paint.html virtual/threaded/inspector/tracing/timeline-paint/update-layer-tree.html virtual/threaded/inspector/tracing/timeline-style/parse-author-style-sheet.html virtual/threaded/inspector/tracing/timeline-style/timeline-recalculate-styles.html virtual/threaded/inspector/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.html virtual/threaded/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidations.html virtual/threaded/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations.html virtual/threaded/inspector/tracing/timeline-time/timeline-time-stamp.html virtual/threaded/inspector/tracing/timeline-time/timeline-time.html virtual/threaded/inspector/tracing/timeline-time/timeline-timer-fired-from-eval-call-site.html virtual/threaded/inspector/tracing/timeline-time/timeline-timer.html virtual/threaded/inspector/tracing/timeline-time/timeline-usertiming.html virtual/threaded/inspector/tracing/worker-events.html virtual/threaded/inspector/tracing/worker-js-frames.html virtual/threaded/printing/absolute-position-headers-and-footers.html virtual/threaded/printing/fixed-positioned-but-static-headers-and-footers.html virtual/threaded/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages.html virtual/threaded/printing/fixed-positioned-headers-and-footers-clipped.html virtual/threaded/printing/fixed-positioned-headers-and-footers-inside-transform.html virtual/threaded/printing/fixed-positioned-headers-and-footers-larger-than-page.html virtual/threaded/printing/fixed-positioned-headers-and-footers.html virtual/threaded/printing/iframe-print.html virtual/threaded/printing/list-item-with-empty-first-line.html virtual/threaded/printing/subframes-percentage-height.html virtual/threaded/transitions/opacity-transform-transitions-inside-iframe.html [2] https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7/builds/47240 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/5538 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/16451 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.9/builds/38576 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/25710 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/19125 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/builds/1174 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Precise/builds/1564 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/8074 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11/builds/12068 Original issue's description: > Turn on Analytic AA in Chrome > > Update cc_unittests png files to reflect our changes. > > We also downgraded some ref tests to pixel tests because > there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the > circle boundaries. This seems to be reasonable as the test html usually > has more layers than the ref html. In the future, we may set a > configurable threshold for ref tests so we don't have to downgrade ref > tests for this reason. > > > BUG= > > patch from issue 2407393003 at patchset 20001 (http://crrev.com/2407393003#ps20001) > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > R=ajuma@chromium.org, fmalita@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/a947a329b3030259fbd042458dd6f31b1fe79dcf TBR=ajuma@google.com,ajuma@chromium.org,jam@google.com,jam@chromium.org,fmalita@chromium.org,reed@google.com,liyuqian@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/7fec161fa71c3f0d694398de1d40aa8d6599a7c3 Cr-Commit-Position: refs/heads/master@{#427953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -4 lines) Patch
M cc/test/data/background_filter_on_scaled_layer_sw.png View Binary file 0 comments Download
M cc/test/data/background_filter_rotated_sw.png View Binary file 0 comments Download
M cc/test/data/rotated_drop_shadow_filter_sw.png View Binary file 0 comments Download
M cc/test/data/rotated_filter_sw.png View Binary file 0 comments Download
M cc/test/data/scaled_render_surface_layer_sw.png View Binary file 0 comments Download
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/images/cross-fade-svg-size-diff-expected.html View 1 chunk +19 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/images/cross-fade-svg-size-diff-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/css3/images/cross-fade-svg-size-expected.html View 1 chunk +8 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/images/cross-fade-svg-size-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/css3/masking/clip-path-restore-expected.html View 1 chunk +20 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/masking/clip-path-restore-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/css3/masking/mask-luminance-svg-expected.html View 1 chunk +32 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/masking/mask-luminance-svg-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/fast/layers/overflow-hidden-rounded-corners-occlusion-expected.html View 1 chunk +10 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/layers/overflow-hidden-rounded-corners-occlusion-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/clipath/clip-path-with-background-and-box-behind-expected.html View 1 chunk +23 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/clipath/clip-path-with-background-and-box-behind-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/svg/canvas/canvas-default-object-sizing-expected.html View 1 chunk +37 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/canvas/canvas-default-object-sizing-expected.png View Binary file 0 comments Download

Messages

Total messages: 6 (2 generated)
alancutter (OOO until 2018)
Created Revert of Turn on Analytic AA in Chrome
4 years, 1 month ago (2016-10-27 06:28:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447013005/1
4 years, 1 month ago (2016-10-27 06:29:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 06:30:35 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 06:32:14 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7fec161fa71c3f0d694398de1d40aa8d6599a7c3
Cr-Commit-Position: refs/heads/master@{#427953}

Powered by Google App Engine
This is Rietveld 408576698