[MD settings] collapse cookie details in subpage

[MD settings] collapse cookie details in subpage

This CL adds collapsing areas for the cookie details in the cookie
settings subpage.

BUG=654943
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e02d9849ea6b00cd15136ee2daba55b5466cf43b
Cr-Commit-Position: refs/heads/master@{#429443}

[dschuyler, 2016-10-27 01:36:11]

Description was changed from

==========
[MD settings] collapse cookie details in subpage

This CL adds collapsing areas for the cookie details in the cookie
settings subpage.

BUG=654943
==========

to

==========
[MD settings] collapse cookie details in subpage

This CL adds collapsing areas for the cookie details in the cookie
settings subpage.

BUG=654943
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-10-27 01:36:13]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 01:36:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 01:38:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 01:38:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dschuyler, 2016-10-27 21:27:11]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2016-10-27 21:27:50]

dschuyler@chromium.org changed reviewers:
+ dbeam@chromium.org

[commit-bot: I haz the power, 2016-10-27 21:27:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 21:33:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 21:33:54]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Dan Beam, 2016-10-27 23:37:15]

lgtm

https://codereview.chromium.org/2457633002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/site_settings/site_data_details_subpage.js
(right):

https://codereview.chromium.org/2457633002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data_details_subpage.js:82:
// Setup flag for expanding cookie details.
Set up

https://codereview.chromium.org/2457633002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data_details_subpage.js:83:
this.entries_.map(function(x) { return x.expanded_ = false; });
why x instead of like e?

[dschuyler, 2016-11-02 21:15:57]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 21:16:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-11-02 21:19:34]

Nits and merge with master

https://codereview.chromium.org/2457633002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/site_settings/site_data_details_subpage.js
(right):

https://codereview.chromium.org/2457633002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data_details_subpage.js:82:
// Setup flag for expanding cookie details.
On 2016/10/27 23:37:15, Dan Beam wrote:
> Set up

Done.

https://codereview.chromium.org/2457633002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data_details_subpage.js:83:
this.entries_.map(function(x) { return x.expanded_ = false; });
On 2016/10/27 23:37:15, Dan Beam wrote:
> why x instead of like e?

Done.

[commit-bot: I haz the power, 2016-11-02 23:06:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 23:06:15]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-11-02 23:07:10]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-11-02 23:07:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2457633002/#ps40001
(title: "merge with master")

[commit-bot: I haz the power, 2016-11-02 23:07:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 23:14:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-02 23:15:21]

Description was changed from

==========
[MD settings] collapse cookie details in subpage

This CL adds collapsing areas for the cookie details in the cookie
settings subpage.

BUG=654943
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] collapse cookie details in subpage

This CL adds collapsing areas for the cookie details in the cookie
settings subpage.

BUG=654943
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e02d9849ea6b00cd15136ee2daba55b5466cf43b
Cr-Commit-Position: refs/heads/master@{#429443}
==========

[commit-bot: I haz the power, 2016-11-02 23:15:22]

Patchset 3 (id:??) landed as
https://crrev.com/e02d9849ea6b00cd15136ee2daba55b5466cf43b
Cr-Commit-Position: refs/heads/master@{#429443}