Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4906)

Unified Diff: chrome/browser/resources/settings/site_settings/site_data_details_subpage.html

Issue 2457633002: [MD settings] collapse cookie details in subpage (Closed)
Patch Set: merge with master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/site_data_details_subpage.html
diff --git a/chrome/browser/resources/settings/site_settings/site_data_details_subpage.html b/chrome/browser/resources/settings/site_settings/site_data_details_subpage.html
index ea776b32f6ba3a11e40aad7064962004efdb3d8d..f983ee614f19370bf7b6b88e325945c55cb9012b 100644
--- a/chrome/browser/resources/settings/site_settings/site_data_details_subpage.html
+++ b/chrome/browser/resources/settings/site_settings/site_data_details_subpage.html
@@ -1,4 +1,6 @@
+<link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expand_button.html">
<link rel="import" href="chrome://resources/html/polymer.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-collapse.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
<link rel="import" href="/route.html">
<link rel="import" href="/settings_shared_css.html">
@@ -14,12 +16,14 @@
<template is="dom-repeat" items="[[entries_]]">
<div class="settings-box" first$="[[!index]]">
<div class="start">[[getEntryDescription_(item)]]</div>
- <!-- TODO(dschuyler): expand/collapse details. -->
+ <cr-expand-button expanded="{{item.expanded_}}">
+ </cr-expand-button>
<paper-icon-button data-id$="[[item.id]]" icon="cr:close"
on-tap="onRemove_">
</paper-icon-button>
</div>
- <div class="list-frame vertical-list">
+ <iron-collapse class="list-frame vertical-list"
+ opened="[[item.expanded_]]">
<template is="dom-repeat" items="[[getCookieNodes_(item)]]">
<div class="list-item two-line">
<div class="start">
@@ -28,7 +32,7 @@
</div>
</div>
</template>
- </div>
+ </iron-collapse>
</template>
</template>
<script src="cookie_info.js"></script>

Powered by Google App Engine
This is Rietveld 408576698